Skip to content

Migrate hipblas usage to V2 APIs. Fixes incompatibility with hipBLAS 3 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amd-nicknick wants to merge 87 commits into
base: master
Choose a base branch
from
Open

Migrate hipblas usage to V2 APIs. Fixes incompatibility with hipBLAS 3 #74

amd-nicknick wants to merge 87 commits into from
+577 −287

Conversation

@amd-nicknick
Copy link

@amd-nicknick amd-nicknick commented Sep 15, 2025

Motivation

Migrate hipBLAS usage to V2 APIs. Fixes incompatibility with hipBLAS 3.x / ROCm 7 where the old API has been removed.

Link: https://rocm.docs.amd.com/projects/hipBLAS/en/develop/reference/deprecation.html#removed-in-hipblas-3-0

Technical Details

  1. Enable HIPBLAS_V2 flag to migrate ROCm 6.x to use the new API.
  2. Update declarations and usage.

Test Plan

cupy GEMM tests.

Test Result

All GEMM tests pass

Submission Checklist

anaruse and others added 30 commits October 4, 2022 20:57
@anaruse
Fixed cupy_thrust.cu for CUDA 11.6
019e27c
Fix missing rocprim identifier
43503bb
@AdrianAbeyta
Merge pull request #2 from ROCmSoftwarePlatform/dev/hubertlu/cupy_thr…
710f6c1 
…ust_fix

Fix missing ROCPrim identifier in cupy_thrust.cu
@amathews-amd
Cherry picked "Fix missing ROCPrim identifier in cupy_thrust.cu"
2bb6d49
@amathews-amd
Merge pull request #3 from ROCmSoftwarePlatform/rocm_5_3_plus_ifu
1b2ed85 
Rocm 5 3 plus ifu
skipped all multi-gpu tests due to non-support
1e2f8fc
skipped multi-gpu nccl tests due to non-multigpu hang
3b27b08
@AdrianAbeyta
Merge pull request #4 from ROCmSoftwarePlatform/skip_multigpu_fft_tests
063e2e8 
Skip multi-gpu unit tests due to non-support for multi-GPU
Merge remote-tracking branch 'upstream/master' into IFU-2023-02-20
547ab1f
fix merge issue
57f4c6d
@lcskrishna
xfail failed tests IFU_2023_02_20
a83638a
@lcskrishna
xfailed tests that fail on rocm
9acc02d
@lcskrishna
skip ndimage_tests and skip tests flaky
92d2243
@lcskrishna
missing import
7fa7b87
Skip manipulation tests causing hang
9d53554
add c++14 for cubreduction
dcedab9
@lcskrishna
skipping flaky tests
43f7134
Skip ndarray tests
3c1df4f
Skip build hip check
ba59d26
@lcskrishna
merging skipped tests from manipulation tests
f609527
@lcskrishna
flake8 white trailing spaces
edcc573
@lcskrishna
trailing spaces
741d4bb
@AdrianAbeyta
Merge pull request #7 from lcskrishna/cl/ifu_2023_02_20
fd8ff83 
[CuPy] xfail the tests failing on IFU-2023-02-20
@AdrianAbeyta
Merge pull request #6 from ROCmSoftwarePlatform/IFU-2023-02-20
c9ff428 
IFU-master-2023-02-20
@pnunna93
Add xfail for test_cumprod_huge_array
739e81f
@AdrianAbeyta
Merge pull request #8 from ROCmSoftwarePlatform/cupy_cumprod_huge_arr
6bc54fd 
Add xfail for test_cumprod_huge_array
@lcskrishna
fix compilation issues in rocm5.6
f2381dd
@lcskrishna
refactor unit test suite automation
70dc62a
@lcskrishna
fix lint issues
71cabdb
@lcskrishna
fix more lint errors
2b40f53
pnunna93 and others added 27 commits August 29, 2023 16:47
@pnunna93
Merge pull request #27 from ROCmSoftwarePlatform/IFU-master-2023-07-31
741027b 
IFU-master-2023-08-15
Fix runtime compile issues for ROCm6.0
2e31c83
Fix conditionals for ROCm6.0
9a33230
fix flake8 cython issues
8543331
@kmaehashi
remove explicit cython installation
61e6027
Update CI
09d53dd
Merge branch 'master' of https://github.com/ROCmSoftwarePlatform/cupy …
c720d04 
…into fix-rocm6.0-compile
@AdrianAbeyta
Merge pull request #38 from ROCmSoftwarePlatform/fix-rocm6.0-compile
432a868 
Update runtime for ROCm6.0 (SWDEV-434155)
Inital bringup of hipGraph
44fb4e5
Fix test_null_stream_cannot_capture graph tests
f69de2c
Update pytests to handle hip
602f570
enable stream capture for hip:blas/rand/solver/sparse
20e2e5e
Clean up comments
63f40bf
Update autopep8
6d5d699
Add backport conditionals for ROCm versions
6fe644b
@lcskrishna
Merge pull request #45 from ROCm/hipgraph_enablement
164f743 
Hipgraph Enablement
Enable cuda_array_interface on ROCm
82a2f11
Modify UT due to ROCm support with cuda_array_interface
e0e2398
@AdrianAbeyta
Merge pull request #55 from ROCm/enable_cuda_array_interface
2a368e4 
Enable cuda array interface for ROCm
@pnunna93
Merge remote-tracking branch 'upstream/main' into IFU-master-2024-11-05
b283c68
@pnunna93
Fix static check errors
d418a99
@pnunna93
Merge remote-tracking branch 'upstream/main' into IFU-master-2024-11-05
04214b4
@pnunna93
Merge branch 'IFU-master-2024-11-05' of https://github.com/ROCm/cupy …
24e350a 
…into IFU-master-2024-11-05
@pnunna93
Add workaround for amdgpu
244841b
@pnunna93
Merge pull request #68 from ROCm/IFU-master-2024-11-05
ff8d2b9 
IFU 2024 11 05
@pnunna93 @lcskrishna
Cherrypick thrust fix (#70)
9cdff17 
* add thrust macros for rocm6.3

* fix code formating for macro

---------

Co-authored-by: lcskrishna <lollachaitanya@gmail.com>
@amd-nicknick
Migrate hipblas usage to V2 APIs. Fixes incompatibility with hipBLAS 3
4a7c9ca
@amd-nicknick amd-nicknick self-assigned this Sep 16, 2025
@gpinkert
Copy link
Collaborator

gpinkert commented Dec 1, 2025

Hi, please use either the latest upstream releases or build using the branch release/rocmds-25.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@amd-nicknick amd-nicknick

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@amd-nicknick @gpinkert @kiritigowda @anaruse @AdrianAbeyta @amathews-amd @lcskrishna @pnunna93 @kmaehashi