Skip to content

Added ?hegvdx#256

Open
mrm24 wants to merge 4 commits intoROCm:developfrom
mrm24:hegvdx
Open

Added ?hegvdx#256
mrm24 wants to merge 4 commits intoROCm:developfrom
mrm24:hegvdx

Conversation

@mrm24
Copy link

@mrm24 mrm24 commented Aug 27, 2025

Motivation

?hegvdx interfaces are missing from hipfort_rocsolver

Technical Details

I've added ?hegvdx interfaces. I've also corrected some issues preventing compilation with amdflang.

Test Plan

I've created a test under test/openmp; the test uses the new amdflang compiler with OpenMP offload for the memory management, testing both omp managed memory and HIPFORT routine. The results are compared against a LAPACK call.

Test Result

Test passes for gfx1102 and amdflang drop 7.0.5.

@mrm24 mrm24 requested a review from cgmb as a code owner August 27, 2025 14:22
@mrm24
Copy link
Author

mrm24 commented Aug 28, 2025

The CI fails when testing if the Fortran compiler can compile a test program:

-- Check for working Fortran compiler: /agent/_work/1/rocm/llvm/bin/flang
-- Check for working Fortran compiler: /agent/_work/1/rocm/llvm/bin/flang - broken
CMake Error at /agent/_work/1/cmake/share/cmake-3.31/Modules/CMakeTestFortranCompiler.cmake:59 (message):
  The Fortran compiler

    "/agent/_work/1/rocm/llvm/bin/flang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/agent/_work/1/s/build/CMakeFiles/CMakeScratch/TryCompile-UJcoPV'
    
    Run Build Command(s): /usr/bin/ninja -v cmTC_71b6b
    [1/4] /agent/_work/1/rocm/llvm/bin/flang -cpp   -Mfree -fPIC -E /agent/_work/1/s/build/CMakeFiles/CMakeScratch/TryCompile-UJcoPV/testFortranCompiler.f > CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f && /agent/_work/1/cmake/bin/cmake -E cmake_ninja_depends --tdi=CMakeFiles/cmTC_71b6b.dir/FortranDependInfo.json --lang=Fortran --src=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f --out=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f --dep=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f.d --obj=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f.o --ddi=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f.o.ddi --src-orig=/agent/_work/1/s/build/CMakeFiles/CMakeScratch/TryCompile-UJcoPV/testFortranCompiler.f
    FAILED: CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f.o.ddi 
    /agent/_work/1/rocm/llvm/bin/flang -cpp   -Mfree -fPIC -E /agent/_work/1/s/build/CMakeFiles/CMakeScratch/TryCompile-UJcoPV/testFortranCompiler.f > CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f && /agent/_work/1/cmake/bin/cmake -E cmake_ninja_depends --tdi=CMakeFiles/cmTC_71b6b.dir/FortranDependInfo.json --lang=Fortran --src=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f --out=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f --dep=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f-pp.f.d --obj=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f.o --ddi=CMakeFiles/cmTC_71b6b.dir/testFortranCompiler.f.o.ddi --src-orig=/agent/_work/1/s/build/CMakeFiles/CMakeScratch/TryCompile-UJcoPV/testFortranCompiler.f
    flang-22: error: unknown argument: '-Mfree'
    ninja: build stopped: subcommand failed.
    
    

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:37 (PROJECT)


-- Configuring incomplete, errors occurred!

##[error]The process '/agent/_work/1/cmake/bin/cmake' failed with exit code 1
##[error]CMake failed with error: The process '/agent/_work/1/cmake/bin/cmake' failed with exit code 1
Finishing:  CMake Flags

Copy link
Collaborator

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants