Open
Conversation
Author
|
The CI fails when testing if the Fortran compiler can compile a test program: |
1 task
cgmb
reviewed
Oct 2, 2025
Collaborator
cgmb
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
?hegvdx interfaces are missing from hipfort_rocsolver
Technical Details
I've added ?hegvdx interfaces. I've also corrected some issues preventing compilation with amdflang.
Test Plan
I've created a test under test/openmp; the test uses the new amdflang compiler with OpenMP offload for the memory management, testing both omp managed memory and HIPFORT routine. The results are compared against a LAPACK call.
Test Result
Test passes for gfx1102 and amdflang drop 7.0.5.