Skip to content

Updates to slurm launcher #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raviguptaamd wants to merge 1 commit into
base: coketaste/refactor-dis
Choose a base branch
from
+843 −8
Open

Updates to slurm launcher #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/madengine/cli/commands/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ def build(
"--batch-manifest", help="Input batch.json file for batch build mode"
),
] = None,
use_image: Annotated[
Optional[str],
typer.Option(
"--use-image",
help="Skip Docker build and use pre-built image (e.g., lmsysorg/sglang:v0.5.2rc1-rocm700-mi30x)"
),
] = None,
build_on_compute: Annotated[
bool,
typer.Option(
"--build-on-compute",
help="Build Docker images on SLURM compute node instead of login node"
),
] = False,
additional_context: Annotated[
str,
typer.Option(
Expand Down Expand Up @@ -183,6 +197,8 @@ def build(
verbose=verbose,
_separate_phases=True,
batch_build_metadata=batch_build_metadata if batch_build_metadata else None,
use_image=use_image,
build_on_compute=build_on_compute,
)

# Initialize orchestrator in build-only mode
Expand All @@ -203,6 +219,8 @@ def build(
clean_cache=clean_docker_cache,
manifest_output=manifest_output,
batch_build_metadata=batch_build_metadata,
use_image=use_image,
build_on_compute=build_on_compute,
)

# Load build summary for display
Expand Down
Loading