Skip to content

Correcting workflow logic so App token is always created and token is used for checkout. Also directly pushes instead of using push action. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zradlicz merged 1 commit into from
May 9, 2025
Merged

Correcting workflow logic so App token is always created and token is used for checkout. Also directly pushes instead of using push action. #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/release-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ jobs:
firmware-version-updated: ${{ steps.compile.outputs.firmware-version-updated }}
release-url: ${{ steps.release.outputs.html_url }}
steps:
# Generate a GitHub App token using the official action
# Generate a GitHub App token using the official action - UNCONDITIONALLY
- name: Create GitHub App token
id: app-token
if: steps.compile.outputs.firmware-version-updated == 'true'
uses: actions/create-github-app-token@v2
with:
app-id: ${{ secrets.APP_ID }}
Expand Down Expand Up @@ -79,10 +78,8 @@ jobs:
# When a GitHub Action pushes commits or tags, it does not trigger a new GitHub Action job
- name: Push changes
if: steps.compile.outputs.firmware-version-updated == 'true'
uses: ad-m/github-push-action@v0.6.0
with:
github_token: ${{ steps.app-token.outputs.token }}
branch: ${{ github.ref }}
run: |
git push origin HEAD:${{ github.ref_name }}

- name: Create archive of target directory
if: steps.compile.outputs.firmware-version-updated == 'true'
Expand All @@ -100,7 +97,7 @@ jobs:
name: "Firmware v${{ steps.compile.outputs.firmware-version }}"
tag: "v${{ steps.compile.outputs.firmware-version }}"
commit: ${{ steps.commit.outputs.updated-version-sha || github.sha }}
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ steps.app-token.outputs.token }}

upload:
name: Upload to Particle
Expand Down
Loading