Conversation
Changed file structure and added documentation for 'roadside turf' organization as a demo of what the updated documentation will look like across organizations.
cleanup readme
zradlicz
left a comment
zradlicz
left a comment
There was a problem hiding this comment.
Is your intention to actually merge to the main branch with this? If so I would suggest leaving the all the files and folders not related to Roadside Turf in place. This way, the only changes are the additions of the new Roadside Turf file and the removal of the old Roadside Turf files. This way, you can merge the branch and then create the future changes to the other projects in a new branch.
If the intention is to continue making the future changes in this branch and not merge to the main branch until those are done, then I would suggest making this a 'draft' pull request which will make it so that it doesn't accidentally get merged with all the files deleted. That way we can review the format change example of Roadside Turf, and then you can make it a real Pull Request once all of the projects are changed.
zradlicz
left a comment
zradlicz
left a comment
There was a problem hiding this comment.
As far as the overall structure, the new method works way better. Separating the queries into individual files was definitely necessary. I'm not fully aware of how grafana works, but if it is directly pulling from this repo for the queries it is using, you should also make sure that this doesn't break any functionality.
2 participants
I've updated the Grafana SQL documentation for the Roadside Turf organization. If the team could review this version and give feedback, once we have an acceptable template for one organization, I can complete the remaining. This is also my first attempt at branching/PR with GitHub, any comments on how to improve this process is also welcomed.