feat: support building with Debian / Ubuntu snapshot services #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Contributor
|
ubuntu的话你传入比如https://snapshot.ubuntu.com/ubuntu/20240301T030400Z/这种行么？ |
RadxaYuntian
reviewed
Jan 5, 2026
| head -n 1 "$1/etc/apt/sources.list" | sed -E -e "s/(%(suite)s)/\\1-backports/" > "$1/etc/apt/sources.list.d/50-%(suite)s-backports.list" | ||
| # security archive | ||
| head -n 1 "$1/etc/apt/sources.list" | sed -E -e "s/(%(suite)s)/\\1-security/" -e "s|/debian |/debian-security |" > "$1/etc/apt/sources.list.d/50-%(suite)s-security.list" | ||
| head -n 1 "$1/etc/apt/sources.list" | sed -E -e "s/(%(suite)s)/\\1-security/" -e "s|/debian([ /])|/debian-security\1|" > "$1/etc/apt/sources.list.d/50-%(suite)s-security.list" |
| distro_mirror_default | ||
| else | ||
| distro_mirror) | ||
| + "/" + |
Contributor
There was a problem hiding this comment.
这算一个breaking change了。这边代码本意是给deb镜像站用的，他们同一个路径下会同时有/debian和/ubuntu，这样就只需要指定一个url就能同时支持两个distro。现在改的需要完整路径了，那就没法一个url
支持多个distro了。看起来的确需要一个单独的参数，并且跟现有的-m要互斥
Contributor
Author
|
ok那我就多增加一个类似 |
Contributor
|
可以直接改好了强推这个分支，然后再继续review |
LZhaoM
changed the title
LZhaoM
commented
Jan 6, 2026
This reverts commit f86fde4.
LZhaoM
force-pushed
the
snapshot-support
branch
from
693bd6d to
bd0bb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个PR目前算是一个
proof-of-concept，目前修改只支持Debian。这样修改的话就能够直接把snapshot的url通过
-m传给rsdk使用，比如：不过因为发现Ubuntu使用snapshot的方法[0]跟Debian有些不太一样所以有些犹豫了，会不会多设置一个
--snapshot命令更好一些？