Added optional support for mcMMO alchemy potions#4
Open
Byteflux wants to merge 1 commit intoRaesWolf:masterfrom
Byteflux:alchemy
Open
Added optional support for mcMMO alchemy potions#4Byteflux wants to merge 1 commit intoRaesWolf:masterfrom Byteflux:alchemy
Byteflux wants to merge 1 commit intoRaesWolf:masterfrom
Byteflux:alchemy
Conversation
Author
|
I think I can do this without hooking into McMMO so that compatibility with other custom potion plugins can be ensured as well. I'll take a look at refactoring this when I get some free time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds optional support for mcMMO alchemy potions as a softdepend.
I hooked into mcMMO to achieve this because the code that subtracts the bit data values from the potion data value was subtracting when it shouldn't for alchemy potions (because alchemy potion data values start at 768).