Conversation
mpsijm
left a comment
mpsijm
left a comment
There was a problem hiding this comment.
Nice that there's a package for this 😄 Some quick comments:
pyproject.toml
Outdated
There was a problem hiding this comment.
~1.8.0 means 1.8.* right? I think this dependency should work with any 1.* version. In generell our dependencies might be overly restrictive?
There was a problem hiding this comment.
Oh woops, I thought that ~=1.8.0 would mean the same as ~=1.8, but apparently not 😂 My intention was ~=1.8 🙂 https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release
We can also go with something more explicit, like ==1.* or >=1.8,<2 (or equivalently >=1.8,==1.*).
our dependencies might be overly restrictive?
Agreed, see also #474 (comment). Feel free to relax the remaining dependencies in a similar way 🙂
There was a problem hiding this comment.
is there some easy way to actually check if another version is compatible? Does mypy check this properly when i change the version or does it rely on what version is already installed?
There was a problem hiding this comment.
I assume that MyPy will simply use whatever is installed. If we install a new minor version and it breaks compatibility, then:
- For packages with their own typings, we may get type errors (as intended, because we should fix the incompatibility)
- For packages with an external types-package, we'll get the same if the types-package is in sync with the regular package
- For Vermin, we should keep our own stubs in sync with the package. So maybe we should use an exact version for Vermin anyway?
There was a problem hiding this comment.
can we setup the CI to install the minimal and maximal matching versions and test both separately?
For Vermin, we should keep our own stubs in sync with the package. So maybe we should use an exact version for Vermin anyway?
Yea that sounds reasonable
There was a problem hiding this comment.
can we setup the CI to install the minimal and maximal matching versions and test both separately?
My guess is that we could run one job with a regular pip install (which will probably(?) install the most recent, compatible version), and in a separate job, run a pip install after replacing all =~ with == in the version range indicators?
There was a problem hiding this comment.
not sure if that works... but also sounds like stuff for the future?
mzuenni
force-pushed
the
vermin
branch
2 times, most recently
from
bab8097 to
f15d2ba
Compare
|
I am not sure where these stubs should actually live? |
I guess we can make a |
|
ready to merge? |
mpsijm
changed the title
mpsijm
left a comment
mpsijm
left a comment
There was a problem hiding this comment.
I pinned the version (see #508 (comment)), and I finally took the time to actually try it out 😛 From that, I have one question, but other than that, this PR is looking good to me 😄
2 participants
No description provided.