Fix --force and --adopt creating empty directories instead of symlinks

[David-Noble-at-work]

Summary

Fixes #127 - --force and --adopt options exhibit destructive behavior that creates empty directories instead of symlinks.

Changes

1. Fix symlink/file removal in remove_files_and_decide_if_adopt()

Before: The removal logic only handled is_dir() and is_file(), missing symlinks that don't resolve:

} else if target_file.is_dir() {
    fs::remove_dir_all(deleted_file).unwrap();
} else if target_file.is_file() {
    fs::remove_file(deleted_file).unwrap();
}

After: Uses exists() || is_symlink() to properly handle all file types including broken symlinks.

2. Fix --adopt deleting source when target doesn't exist

Before: The source file in the dotfiles repo was deleted unconditionally before checking if the target existed.

After: Now checks if target exists before deleting source, with a warning message if adopt is not possible.

3. Fix directory creation in SymlinkHandler::add()

Before: After removing a file, target_path.is_file() returns false, causing create_dir_all(&target_path) to create the target as a directory:

fs::create_dir_all(if target_path.is_file() {
    target_path.parent().unwrap()
} else {
    &target_path  // BUG: creates target as directory!
})

After: Always uses .parent() to only create parent directories.

Testing

• cargo check passes
• cargo test passes (except for pre-existing unrelated failure in ignore_garbage_files)
• The add_and_remove_symlink test passes

Impact

These bugs caused 185+ files to become empty directories when using --force, affecting SSH keys, shell configs, fonts, and other critical dotfiles.

[RaphGL]

Why is this added? The program should fail before this should even be necessary. Also no_x_setup_yet exists and is used throughout the program. introducing this is completely unncessary.

[RaphGL]

I just opened your fork, your fork is outdated. I just did some work to fix the bad handling of multiple groups sharing files the recently. Please test the most recent version to see if the issue has been fixed.

[RaphGL]

I cannot even replicate the issue you hint at here. Was this an AI PR?