Skip to content

Conversation

@Raskolnikofff
Copy link
Owner

No description provided.

@Raskolnikofff Raskolnikofff reopened this Dec 25, 2020
@Raskolnikofff Raskolnikofff self-assigned this Dec 28, 2020
@ongrid ongrid self-requested a review December 29, 2020 07:16
@Raskolnikofff Raskolnikofff requested a review from ongrid January 3, 2021 12:40
@Raskolnikofff
Copy link
Owner Author

when setting up the address /. when testing in the browser, this address was rolled back to / so I made the address /swagger

Copy link
Collaborator

@ongrid ongrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need schema (definition) for the Student and corresponding relations. Responses need to be specified using type, items and so on.

responses:
'200':
description: 'OK'
post:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic error at paths./students/{id}.post
Operations with parameters of "in: formData" must include "application/x-www-form-urlencoded" or "multipart/form-data" in their "consumes" property
Jump to line 44

Check with https://editor.swagger.io/

tags:
- "student on course"
responses:
'200':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the schema of the response? Since the student is a complex object, just 200 OK is not enough.

@ongrid
Copy link
Collaborator

ongrid commented Feb 10, 2021

"This branch has conflicts that must be resolved"

@ongrid
Copy link
Collaborator

ongrid commented Feb 10, 2021

need rebase on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants