Add sqlalchemy ORM and change function in view.py for the database #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ongrid
requested changes
Feb 4, 2021
| surname = sql.Column(sql.String) | ||
|
|
||
|
|
||
| # Help lines |
Collaborator
There was a problem hiding this comment.
This shouldn't be in the codebase.
Keep it in tests' fixtures or separate helper scripts
| @@ -0,0 +1,37 @@ | |||
| from sqlalchemy.orm import sessionmaker | |||
Collaborator
There was a problem hiding this comment.
filename ORM is not conventional.
More conventional name is model.py or some_application.py.
snake_case is preferred for all the naming options in python (except Classes)
Collaborator
|
This branch has conflicts that must be resolved rebase it to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.