Skip to content

fix: Show persistent error card when patch bundle download fails#2965

Open
Aunali321 wants to merge 3 commits intoReVanced:devfrom
Aunali321:fix/api-error-ui
Open

fix: Show persistent error card when patch bundle download fails#2965
Aunali321 wants to merge 3 commits intoReVanced:devfrom
Aunali321:fix/api-error-ui

Conversation

@Aunali321
Copy link
Contributor

What it does: Shows a persistent warning card on the dashboard when the API URL is invalid/unreachable. Closes #2050

Test steps:

  1. Install the APK
  2. Go to Settings → Advanced → API URL and set it to something invalid (e.g. https://invalid.example.com)
  3. Go back to Dashboard
  4. You should see a card saying "Patches could not be downloaded. Check your API URL in settings."
  5. Tapping the card should navigate to Settings
  6. Fix the API URL back to default. The card should disappear after patches reload
Screenshot_20260227_063816_ReVanced Manager (Debug)

@oSumAtrIX
Copy link
Member

This shouldnt just show up for not being able to download patches only but for any api error and should instead say "API not working" similar to the website doing it.

@Ushie
Copy link
Member

Ushie commented Feb 27, 2026

That can be a separate feat

@Ushie
Copy link
Member

Ushie commented Feb 27, 2026

But this one should be normalized to also apply to any remote patch bundle

@oSumAtrIX
Copy link
Member

This shouldnt be merged as is. The main idea of this PR is to note if the api is down essentially, so its not about patches per se

@Aunali321
Copy link
Contributor Author

Aunali321 commented Feb 27, 2026

It checks API status not just patches. Updates are also affected for example

@oSumAtrIX
Copy link
Member

Then the dialog should say that

@Aunali321
Copy link
Contributor Author

@oSumAtrIX Message now says "API is not reachable" instead of patches-specific text
@Ushie The error tracking already applies to all remote patch bundles

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Feb 27, 2026

Does it show that when api times out and isnt available? If so, lgtm, its not descriptive though so people would not understand whats going on. Take a peak at how website does it:

image

you can enter a bogus api:

image

@Aunali321
Copy link
Contributor Author

@oSumAtrIX
Yes, it shows when api timeouts. Is this better? Title might a bit large but that's the default value in codebase
Screenshot_20260227_200256_ReVanced Manager (Debug)

@oSumAtrIX
Copy link
Member

better but font size is too big. Design can be done by someone else in our team, just the features are important for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants