Conversation
pTinosq
approved these changes
Sep 10, 2025
Contributor
pTinosq
left a comment
pTinosq
left a comment
There was a problem hiding this comment.
LGTM other than one minor version adjustment
.github/workflows/e2e_tests.yaml
Outdated
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| version: "0.7.2" |
Contributor
There was a problem hiding this comment.
Should this not be 0.7.20 to match the version in the Makefile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates an initial E2E workflow. The workflow is incomplete but it needs to be merged into main for further testing.
Review by RecurseML
🔍 Review performed on b96f6ef..c0e566b
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
•
.github/workflows/e2e_tests.yaml•
tests/e2e/test_e2e.py⏭️ Files skipped (trigger manually) (1)
.gitignore