fix: use admin client for node object to avoid unprivileged 403 errors

[geetikakay]

VMs created with unprivileged_client pass that client down to the Node object via vmi.node. Node is cluster-scoped so unprivileged users can't query node status causing 403 Forbidden in wait_for_node_status.

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

[coderabbitai]

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

• WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[geetikakay]

/wip
testing pending

[geetikakay]

/wip cancel

[rnetser]

/approve
/lgtm

[geetikakay]

/verified
I have verified these changes locally

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file
2. Identify affected code paths, functions, and classes
3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
4. Trace test dependencies through imports, shared utilities, and fixture inheritance
5. Detect new tests introduced in the PR
6. Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
   • Changes to files/functions used by tests marked with @pytest.mark.smoke
   • Changes to fixtures or utilities imported by smoke tests
   • Changes to conftest.py files that may affect smoke test execution
   • Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

• Include only tests directly affected by the changes
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name if only specific tests are needed
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the list of changed files in this PR
gh pr view 3948 --json files --jq '.files[].path'

Length of output: 185

---

🏁 Script executed:

#!/bin/bash
# Get the diff for this PR to see what changed
gh pr diff 3948

Length of output: 6064

---

🏁 Script executed:

#!/bin/bash
# Find tests that use unprivileged_client
rg "unprivileged_client" --type=py -n -C3

Length of output: 265316

---

🏁 Script executed:

#!/bin/bash
# Find all smoke tests
rg "pytest.mark.smoke" --type=py -n -B2 | grep "def test_"

Length of output: 0

---

🏁 Script executed:

#!/bin/bash
# 1) Find where the changed remediation_fencing fixtures are used
rg -n --type=py -C2 $'\\b(vm_node_before_failure|performed_node_operation)\\b' tests/infrastructure/workload_availability || true

Length of output: 2976

---

🏁 Script executed:

#!/bin/bash
#!/usr/bin/env bash
set -euo pipefail

PR_NUMBER=3948
FIRST_FILE_PATH="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].path')"

# Fetch the patch for the first changed file
PATCH_CONTENT="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].patch')"

# Compute the "position" of the first added line in the patch (GitHub review comment API expects 1-based index in patch).
# We skip lines that start with 'diff ', 'index ', '---', '+++' if they ever appear in patch payload (usually not), and count from first '@@' hunk.
python - << 'PY'
import os, sys, textwrap, json

patch = os.environ.get("PATCH_CONTENT","")
lines = patch.splitlines()
position = None
in_hunk = False
for idx, line in enumerate(lines, start=1):
    if line.startswith('@@ '):
        in_hunk = True
        continue
    if not in_hunk:
        continue
    # First actual added/changed line visible in hunk (prefer a '+' addition over context ' ')
    if line.startswith('+') and not line.startswith('+++'):
        position = idx
        break

# Fallback: if no '+' found (unlikely), anchor to the first hunk header line itself
if position is None:
    for idx, line in enumerate(lines, start=1):
        if line.startswith('@@ '):
            position = idx + 1
            break

print(position if position is not None else 1)
PY

Length of output: 1

---

🏁 Script executed:

#!/bin/bash
#!/usr/bin/env bash
set -euo pipefail

PR_NUMBER=3948
REPO="RedHatQE/openshift-virtualization-tests"

FIRST_FILE_PATH="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].path')"
PATCH_CONTENT="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].patch')"

POSITION="$(python - << 'PY'
import os, sys
patch = os.environ.get("PATCH_CONTENT","")
lines = patch.splitlines()
position = None
in_hunk = False
for idx, line in enumerate(lines, start=1):
    if line.startswith('@@ '):
        in_hunk = True
        continue
    if not in_hunk:
        continue
    if line.startswith('+') and not line.startswith('+++'):
        position = idx
        break
if position is None:
    for idx, line in enumerate(lines, start=1):
        if line.startswith('@@ '):
            position = idx + 1
            break
print(position if position is not None else 1)
PY
)"

# Build Test Execution Plan content
read -r -d '' BODY << 'EOF'
Test Execution Plan

- Run smoke tests: False

Directly affected by admin-client Node access change (vmi.node -> node_for_vmi(admin_client,...)):
- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_container_disk_reboot
- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_dv_disk_reboot

Notes:
- Change introduces tests/infrastructure/utils.py::node_for_vmi() and updates fixtures in remediation_fencing/conftest.py to use admin_client when constructing ocp_resources.node.Node.
- No pytest.mark.smoke found in repository; no verified dependency path from smoke tests to changed code.
EOF

# Post as an inline review comment on the first changed line of the first file.
# Per repository guidance: use create-review API with event=COMMENT and put content in comments[].body; leave top-level body empty.
gh api -X POST "repos/${REPO}/pulls/${PR_NUMBER}/reviews" \
  -f event='COMMENT' \
  -f comments[][path]="$FIRST_FILE_PATH" \
  -f comments[][position]="$POSITION" \
  -f comments[][body]="$BODY" >/dev/null

Length of output: 0

---

@coderabbit-user

---

🏁 Script executed:

#!/bin/bash
# Collect specific test function names from remediation_fencing test files
set -euo pipefail

files=(
  "tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_fenceagent_remediation.py"
  "tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_default_remediation.py"
)

for f in "${files[@]}"; do
  if [ -f "$f" ]; then
    echo "$f:"
    rg -nP '^\s*def\s+(test_[A-Za-z0-9_]+)\s*\(' "$f" -r '$1' | awk '{print "  "::"$f::"$0}'
  else
    echo "$f not found" >&2
  fi
done

Length of output: 195

---

🏁 Script executed:

#!/bin/bash
# Post (or re-post) the inline Test Execution Plan on the first changed line of the first file
set -euo pipefail

PR_NUMBER=3948
REPO="RedHatQE/openshift-virtualization-tests"

FIRST_FILE_PATH="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].path')"
PATCH_CONTENT="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].patch')"

POSITION="$(python - << 'PY'
import os
patch = os.environ.get("PATCH_CONTENT","")
lines = patch.splitlines()
position = None
in_hunk = False
for idx, line in enumerate(lines, start=1):
    if line.startswith('@@ '):
        in_hunk = True
        continue
    if not in_hunk:
        continue
    if line.startswith('+') and not line.startswith('+++'):
        position = idx
        break
if position is None:
    for idx, line in enumerate(lines, start=1):
        if line.startswith('@@ '):
            position = idx + 1
            break
print(position if position is not None else 1)
PY
)"

# Derive specific test names from remediation_fencing files (fallback to file-only if parsing fails)
RF_FENCEAGENT_FILE="tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_fenceagent_remediation.py"
RF_DEFAULT_FILE="tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_default_remediation.py"

get_tests_for_file () {
  local f="$1"
  if [ -f "$f" ]; then
    rg -nP '^\s*def\s+(test_[A-Za-z0-9_]+)\s*\(' "$f" -r "$f::\$1" || true
  fi
}

FENCEAGENT_TESTS="$(get_tests_for_file "$RF_FENCEAGENT_FILE")"
DEFAULT_TESTS="$(get_tests_for_file "$RF_DEFAULT_FILE")"

# Build execution plan body
read -r -d '' BODY << EOF || true
Test Execution Plan

- Run smoke tests: False

Directly affected by admin-client Node access change (vmi.node -> node_for_vmi(admin_client,...)):

- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_container_disk_reboot
- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_dv_disk_reboot
$(if [ -n "$FENCEAGENT_TESTS" ]; then echo "$FENCEAGENT_TESTS" | sed 's/^/- /'; else echo "- $RF_FENCEAGENT_FILE"; fi)
$(if [ -n "$DEFAULT_TESTS" ]; then echo "$DEFAULT_TESTS" | sed 's/^/- /'; else echo "- $RF_DEFAULT_FILE"; fi)

Notes:
- Introduces tests/infrastructure/utils.py::node_for_vmi() and updates remediation_fencing fixtures to use admin_client when constructing ocp_resources.node.Node.
- Verified no `@pytest.mark.smoke` usage in repo; no traceable dependency chain from smoke tests to the changed code, so running smoke suite is unnecessary per project policy.
EOF

# Post the inline comment on the first changed line of the first file.
gh api -X POST "repos/${REPO}/pulls/${PR_NUMBER}/reviews" \
  -f event='COMMENT' \
  -f comments[][path]="$FIRST_FILE_PATH" \
  -f comments[][position]="$POSITION" \
  -f comments[][body]="$BODY" >/dev/null

Length of output: 80

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

PR_NUMBER=3948
REPO="RedHatQE/openshift-virtualization-tests"

FIRST_FILE_PATH="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].path')"
PATCH_CONTENT="$(gh pr view "$PR_NUMBER" --json files --jq '.files[0].patch')"

export PATCH_CONTENT
POSITION="$(python - << 'PY'
import os
patch = os.environ.get("PATCH_CONTENT","")
lines = patch.splitlines()
pos = None
in_hunk = False
for idx, line in enumerate(lines, start=1):
    if line.startswith('@@ '):
        in_hunk = True
        continue
    if not in_hunk:
        continue
    if line.startswith('+') and not line.startswith('+++'):
        pos = idx
        break
if pos is None:
    for idx, line in enumerate(lines, start=1):
        if line.startswith('@@ '):
            pos = idx + 1
            break
print(pos or 1)
PY
)"

# Derive specific tests from remediation_fencing files; fallback to file path if none found.
RF_FENCEAGENT_FILE="tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_fenceagent_remediation.py"
RF_DEFAULT_FILE="tests/infrastructure/workload_availability/remediation_fencing/test_nodehealthcheck_default_remediation.py"

FENCEAGENT_TESTS=""
if [ -f "$RF_FENCEAGENT_FILE" ]; then
  FENCEAGENT_TESTS="$(rg -nP '^\s*def\s+(test_[A-Za-z0-9_]+)\s*\(' "$RF_FENCEAGENT_FILE" -r '$1' | sed "s|^|$RF_FENCEAGENT_FILE::|")" || true
fi

DEFAULT_TESTS=""
if [ -f "$RF_DEFAULT_FILE" ]; then
  DEFAULT_TESTS="$(rg -nP '^\s*def\s+(test_[A-Za-z0-9_]+)\s*\(' "$RF_DEFAULT_FILE" -r '$1' | sed "s|^|$RF_DEFAULT_FILE::|")" || true
fi

FENCEAGENT_BLOCK="- $RF_FENCEAGENT_FILE"
if [ -n "$FENCEAGENT_TESTS" ]; then
  FENCEAGENT_BLOCK="$(printf '%s\n' "$FENCEAGENT_TESTS" | sed 's/^/- /')"
fi

DEFAULT_BLOCK="- $RF_DEFAULT_FILE"
if [ -n "$DEFAULT_TESTS" ]; then
  DEFAULT_BLOCK="$(printf '%s\n' "$DEFAULT_TESTS" | sed 's/^/- /')"
fi

cat > body.txt <<EOF
Test Execution Plan

- Run smoke tests: False

Directly affected by admin-client Node access change (vmi.node -> node_for_vmi(admin_client,...)):

- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_container_disk_reboot
- tests/infrastructure/workload_availability/remediation_fencing_mhc/test_ha_vm.py::test_ha_vm_dv_disk_reboot
$FENCEAGENT_BLOCK
$DEFAULT_BLOCK

Notes:
- Introduces tests/infrastructure/utils.py::node_for_vmi() and updates remediation_fencing fixtures to use admin_client when constructing ocp_resources.node.Node.
- Verified no `@pytest.mark.smoke` usage in repo; no traceable dependency path from smoke tests to the changed code, so running smoke suite is unnecessary per project policy.
EOF

export FIRST_FILE_PATH POSITION
python - << 'PY' | gh api -X POST "repos/RedHatQE/openshift-virtualization-tests/pulls/3948/reviews" --input -
import os, json
with open('body.txt','r',encoding='utf-8') as f:
    body=f.read()
data={
  "event":"COMMENT",
  "comments":[
    {
      "path": os.environ["FIRST_FILE_PATH"],
      "position": int(os.environ["POSITION"]),
      "body": body
    }
  ]
}
print(json.dumps(data))
PY

Length of output: 1735

---

---

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: For PR `#1904` test execution, the critical validation point is test_connectivity_over_migration_between_localnet_vms which should fail gracefully on cloud clusters but pass on bare-metal/PSI clusters, representing the core nmstate conditional logic functionality.

---

Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3612
File: tests/network/user_defined_network/ip_specification/test_ip_specification.py:10-10
Timestamp: 2026-01-26T20:29:54.623Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when introducing STD (Standard Test Definition) PRs that define test case structure without implementation, it's acceptable and intentional to use `__test__ = False` to block pytest collection until the tests are fully implemented in a follow-up PR. The STD workflow involves: (1) defining test structure, markers, and documentation first, (2) implementing the actual test logic and removing the collection blocker in a subsequent PR.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:44.327Z
Learning: For PRs that remove test cases (especially redundant test cleanup PRs in openshift-virtualization-tests), test collection verification (pytest --collect-only showing selected/deselected counts) is sufficient to confirm the removal was clean and the test module remains functional. Full test execution is not required for test deletion PRs.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:26.819Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers to avoid nitpicky style changes (e.g., removing `.keys()` from dict membership checks) because verifying every change is expensive. Be cautious about suggesting low-impact stylistic improvements that require verification overhead.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

---

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-07T14:51:53.484Z
Learning: In the openshift-virtualization-tests repository, the team has decided to avoid using predefined time constants (like TIMEOUT_2MIN, TIMEOUT_5SEC) and prefers using explicit numeric values for timeout parameters.