Add windows.2k3 and windows.xp to VM preferences list

[geetikakay]

Short description:

Add windows.2k3 and windows.xp to VM preferences list
Assisted-by :Cursor

More details:

What this PR does / why we need it:

for fixing failed test runs for 4.19 due to missing preferences

Which issue(s) this PR fixes:

Jenkins failure for missing preferences

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• New Features
  • Expanded Windows virtual machine variant support to include Windows 2003 and Windows XP options.

[coderabbitai]

Walkthrough

Two Windows operating system versions ("windows.2k3" and "windows.xp") are added to the existing Windows VM preference list in the VM_PREFERENCES_LIST constant. No structural modifications or other changes are present.

Changes

Cohort / File(s)	Summary
Windows VM Preference List tests/infrastructure/instance_types/vm_preference_list.py	Added "windows.2k3" and "windows.xp" entries to the Windows VM preferences data structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is incomplete with several empty or unclear sections that make it difficult to fully assess the motivation and impact.	Complete the 'More details' section, clarify the Jenkins failure context, provide the full Jira ticket URL or confirm 'NONE', and expand 'Special notes for reviewer' with relevant information about testing or compatibility concerns.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: adding two Windows versions to the VM preferences list.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-5]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[geetikakay]

/verified locally

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file
2. Identify affected code paths, functions, and classes
3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
4. Trace test dependencies through imports, shared utilities, and fixture inheritance
5. Detect new tests introduced in the PR
6. Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
   • Changes to files/functions used by tests marked with @pytest.mark.smoke
   • Changes to fixtures or utilities imported by smoke tests
   • Changes to conftest.py files that may affect smoke test execution
   • Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

• Include only tests directly affected by the changes
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name if only specific tests are needed
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch the PR details to see what files were changed
gh pr view 3961 --repo RedHatQE/openshift-virtualization-tests --json files,additions,deletions | jq -r '.files[] | "\(.path)"'

Length of output: 57

---

🏁 Script executed:

#!/bin/bash
# Get the diff for this PR to see the actual changes
gh pr diff 3961 --repo RedHatQE/openshift-virtualization-tests

Length of output: 596

---

🏁 Script executed:

#!/bin/bash
# Read the full content of the changed file to understand its purpose
cat tests/infrastructure/instance_types/vm_preference_list.py

Length of output: 1379

---

🏁 Script executed:

#!/bin/bash
# Find tests or code that imports or uses this file
rg "from.*vm_preference_list import|import.*vm_preference_list" --type=py -n

Length of output: 153

---

🏁 Script executed:

#!/bin/bash
# Search for any direct usage of the constants defined in this file
rg "VM_PREFERENCES_LIST|RHEL_PREFERENCES|CENTOS_PREFERENCES|FEDORA_PREFERENCES|WINDOWS_PREFERENCES" --type=py -n -C2

Length of output: 3108

---

🏁 Script executed:

#!/bin/bash
# Check the test file that uses VM_PREFERENCES_LIST to understand test structure
cat tests/infrastructure/instance_types/test_common_vm_preference.py

Length of output: 5124

---

🏁 Script executed:

#!/bin/bash
# Check if any tests in test_common_vm_preference.py are marked as smoke tests
rg "pytest.mark.smoke" tests/infrastructure/instance_types/test_common_vm_preference.py -n -C3

Length of output: 0

---

🏁 Script executed:

#!/bin/bash
# Find all smoke tests in the repository to check if any import or use vm_preference_list
rg "@pytest.mark.smoke" --type=py -l | head -20

Length of output: 313

---

🏁 Script executed:

#!/bin/bash
# Check if any smoke tests import or reference vm_preference_list
for file in tests/virt/node/general/test_container_disk_vm.py tests/storage/cdi_upload/test_upload_virtctl.py tests/storage/cdi_clone/test_clone.py tests/virt/cluster/common_templates/rhel/test_rhel_os_support.py tests/install_upgrade_operators/csv/test_csv.py tests/infrastructure/instance_types/supported_os/test_rhel_os.py; do
  echo "=== Checking $file ==="
  rg "vm_preference_list|VM_PREFERENCES_LIST" "$file" || echo "No match"
done

Length of output: 469

---

🏁 Script executed:

#!/bin/bash
# Check if smoke tests import from instance_types module
for file in tests/virt/node/general/test_container_disk_vm.py tests/storage/cdi_upload/test_upload_virtctl.py tests/storage/cdi_clone/test_clone.py tests/virt/cluster/common_templates/rhel/test_rhel_os_support.py tests/install_upgrade_operators/csv/test_csv.py tests/infrastructure/instance_types/supported_os/test_rhel_os.py; do
  echo "=== Imports in $file ==="
  grep -n "^from\|^import" "$file" | head -20
done

Length of output: 1984

---

🏁 Script executed:

#!/bin/bash
# Get more details on the markers in the affected test file
rg "@pytest.mark" tests/infrastructure/instance_types/test_common_vm_preference.py -n

Length of output: 368

---

🏁 Script executed:

#!/bin/bash
# Post inline review comment with test execution plan on the first changed line
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/RedHatQE/openshift-virtualization-tests/pulls/3961/comments" \
  -f body="## Test Execution Plan

**Run smoke tests: False**

This PR adds \`windows.2k3\` and \`windows.xp\` to the VM preferences list. The changes only affect tests that validate VM preferences in the instance_types test suite.

### Tests to Execute:

- \`tests/infrastructure/instance_types/test_common_vm_preference.py::test_base_preferences_common_annotation\` - Verify the new preferences exist in the cluster
- \`tests/infrastructure/instance_types/test_common_vm_preference.py::TestCommonVmPreference::test_common_vm_preference_windows\` - Test VM creation with Windows preferences including the two new entries

### Rationale:

The change is a data-only addition to the \`VM_PREFERENCES_LIST\` dictionary. No smoke tests import or depend on this module. The affected tests validate that cluster preferences match the expected list and test VM creation with various preference types." \
  -f commit_id="$(gh pr view 3961 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q .headRefOid)" \
  -f path="tests/infrastructure/instance_types/vm_preference_list.py" \
  -f side="RIGHT" \
  -f line=33

Length of output: 675

---

🏁 Script executed:

#!/bin/bash
# Try with the correct API format using start_line and line
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/RedHatQE/openshift-virtualization-tests/pulls/3961/comments" \
  -f body="## Test Execution Plan

**Run smoke tests: False**

This PR adds \`windows.2k3\` and \`windows.xp\` to the VM preferences list. The changes only affect tests that validate VM preferences in the instance_types test suite.

### Tests to Execute:

- \`tests/infrastructure/instance_types/test_common_vm_preference.py::test_base_preferences_common_annotation\` - Verify the new preferences exist in the cluster
- \`tests/infrastructure/instance_types/test_common_vm_preference.py::TestCommonVmPreference::test_common_vm_preference_windows\` - Test VM creation with Windows preferences including the two new entries

### Rationale:

The change is a data-only addition to the \`VM_PREFERENCES_LIST\` dictionary. No smoke tests import or depend on this module. The affected tests validate that cluster preferences match the expected list and test VM creation with various preference types." \
  -f commit_id="$(gh pr view 3961 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q .headRefOid)" \
  -f path="tests/infrastructure/instance_types/vm_preference_list.py" \
  -f side="RIGHT" \
  -F start_line=33 \
  -F line=33 \
  -f subject_type="line"

Length of output: 622

---

🏁 Script executed:

#!/bin/bash
# Get the diff with unified format to calculate position
gh pr diff 3961 --repo RedHatQE/openshift-virtualization-tests > /tmp/pr_diff.txt
cat /tmp/pr_diff.txt

Length of output: 596

---

🏁 Script executed:

#!/bin/bash
# Count lines in the diff to find position of line 33 (the first added line with windows.2k3)
# Position is the line number in the diff, not the file
awk '/^@@.*@@/{p=0; next} /^\+.*windows\.2k3/{print NR; exit} {p++}' /tmp/pr_diff.txt

Length of output: 1

---

🏁 Script executed:

#!/bin/bash
# Try using the reviews endpoint instead with correct position calculation
# Position 6 should be the first + line for windows.2k3
COMMIT_SHA=$(gh pr view 3961 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q .headRefOid)

gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/RedHatQE/openshift-virtualization-tests/pulls/3961/reviews" \
  -f commit_id="$COMMIT_SHA" \
  -f event="COMMENT" \
  -f 'comments[0][path]=tests/infrastructure/instance_types/vm_preference_list.py' \
  -f 'comments[0][position]=6' \
  -f 'comments[0][body]=## Test Execution Plan

**Run smoke tests: False**

This PR adds `windows.2k3` and `windows.xp` to the VM preferences list. The changes only affect tests that validate VM preferences in the instance_types test suite.

### Tests to Execute:

- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_base_preferences_common_annotation` - Verify the new preferences exist in the cluster
- `tests/infrastructure/instance_types/test_common_vm_preference.py::TestCommonVmPreference::test_common_vm_preference_windows` - Test VM creation with Windows preferences including the two new entries

### Rationale:

The change is a data-only addition to the `VM_PREFERENCES_LIST` dictionary. No smoke tests import or depend on this module. The affected tests validate that cluster preferences match the expected list and test VM creation with various preference types.'

Length of output: 2293

---

🏁 Script executed:

#!/bin/bash
# Use proper JSON array format for comments
COMMIT_SHA=$(gh pr view 3961 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q .headRefOid)

cat > /tmp/review_payload.json <<'EOF'
{
  "commit_id": "COMMIT_SHA_PLACEHOLDER",
  "event": "COMMENT",
  "comments": [
    {
      "path": "tests/infrastructure/instance_types/vm_preference_list.py",
      "position": 6,
      "body": "## Test Execution Plan\n\n**Run smoke tests: False**\n\nThis PR adds `windows.2k3` and `windows.xp` to the VM preferences list. The changes only affect tests that validate VM preferences in the instance_types test suite.\n\n### Tests to Execute:\n\n- `tests/infrastructure/instance_types/test_common_vm_preference.py::test_base_preferences_common_annotation` - Verify the new preferences exist in the cluster\n- `tests/infrastructure/instance_types/test_common_vm_preference.py::TestCommonVmPreference::test_common_vm_preference_windows` - Test VM creation with Windows preferences including the two new entries\n\n### Rationale:\n\nThe change is a data-only addition to the `VM_PREFERENCES_LIST` dictionary. No smoke tests import or depend on this module. The affected tests validate that cluster preferences match the expected list and test VM creation with various preference types."
    }
  ]
}
EOF

# Replace placeholder with actual commit SHA
sed -i "s/COMMIT_SHA_PLACEHOLDER/$COMMIT_SHA/" /tmp/review_payload.json

# Post the review
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/RedHatQE/openshift-virtualization-tests/pulls/3961/reviews" \
  --input /tmp/review_payload.json

Length of output: 1735

---

---

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:44.327Z
Learning: For PRs that remove test cases (especially redundant test cleanup PRs in openshift-virtualization-tests), test collection verification (pytest --collect-only showing selected/deselected counts) is sufficient to confirm the removal was clean and the test module remains functional. Full test execution is not required for test deletion PRs.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

---

Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3612
File: tests/network/user_defined_network/ip_specification/test_ip_specification.py:10-10
Timestamp: 2026-01-26T20:29:54.623Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when introducing STD (Standard Test Definition) PRs that define test case structure without implementation, it's acceptable and intentional to use `__test__ = False` to block pytest collection until the tests are fully implemented in a follow-up PR. The STD workflow involves: (1) defining test structure, markers, and documentation first, (2) implementing the actual test logic and removing the collection blocker in a subsequent PR.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:26.819Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers to avoid nitpicky style changes (e.g., removing `.keys()` from dict membership checks) because verifying every change is expensive. Be cautious about suggesting low-impact stylistic improvements that require verification overhead.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

---

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-07T14:51:53.484Z
Learning: In the openshift-virtualization-tests repository, the team has decided to avoid using predefined time constants (like TIMEOUT_2MIN, TIMEOUT_5SEC) and prefers using explicit numeric values for timeout parameters.

[SamAlber]

/lgtm

[geetikakay]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[rnetser]

/approve
/lgtm

[openshift-virtualization-qe-bot-5]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.19 published