-
Notifications
You must be signed in to change notification settings - Fork 41
Added James’ individual contributions (mental_health_hub demo) #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Includes logging demo, Flask JWT authentication, Streamlit hub app, storytelling module, and associated documentation.
🔒 Security Scan Results⛔️ Critical vulnerabilities detected. Please review and address these security issues before merging. Next Steps:
|
Mouse933
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please see the comments attached to the test logging files for some questions I've asked regarding the credentials shown in plaintext there, just needing clarification on how that works.
Outside this, Bandit has picked up a possible high priority security issue with your code, see the details below. These issues need to be addressed before this can be merged thanks :)
Issue: [B201:flask_debug_true] A Flask app appears to be run with debug=True, which exposes the Werkzeug debugger and allows the execution of arbitrary code.
Severity: High Confidence: Medium
CWE: CWE-94 (https://cwe.mitre.org/data/definitions/94.html)
More Info: https://bandit.readthedocs.io/en/1.8.6/plugins/b201_flask_debug_true.html
Location: ./mental_health_hub (James Nardella)/flask_jwt_demo/Token-Based Authentication (JWT).py:110:4
109 if name == "main":
110 app.run(debug=True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious regarding this test API, as it does seem to have hardcoded values stored on it, is there any way outside users can access this? Or is it simply an isolated testing unit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again as this accepts any password for the correct accounts, I would like to know how this logging demo functions as part of the full program. Thanks :)
Summary
This PR adds my individual contributions for the Mental Health Hub project.
Includes:
Notes
mental_health_hub (James Nardella)folder.