-
Notifications
You must be signed in to change notification settings - Fork 41
Add files via upload #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add files via upload #149
Conversation
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
🔒 Security Scan Results✅ No critical security issues detected. The code has passed all critical security checks. |
| # ----------------------------- | ||
| # PIN setup (safe fallback) | ||
| # ----------------------------- | ||
| DEFAULT_PIN = "1234" # fallback PIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking is the PIN here something that's set as a hardcoded value only when a fallback is needed? Or is anyone able to login to an account using it? So if someone were to get hold of someones account or device, would they be able to use the fallback pin to login?
Mouse933
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please see the comment I added to the discussion regarding the hardcoded pin. Likewise, check over the files and make sure they meet the companies naming conventions for files and variables as the pull request checks failed.
Outside this, the rest looks good, just a few changes needed before this can be pushed :)
What are the changes?
Who worked on the changes?
New Components/Features
Enhanced Components/Features
Other Changes/Fixes
Additional Notes
TODOs
Checklist
Screenshots or example output