Merged
Conversation
Introduce a manylinux-based Linux build and improve PyInstaller invocation for platform compatibility. Added build-manylinux.sh to compile and install Python 3.14.3 inside a manylinux_2_28 container, create a venv, install deps and run the existing build.sh inside the container. Update CI and release workflows to run setup-python and dependency installs only on Windows, and to run the manylinux Dockerized build for non-Windows runners. Adjust build.sh shebang to /bin/bash and add hidden-imports for pynput X11 backends; similarly add hidden-imports for pynput Win32 backends in build.ps1 to ensure PyInstaller collects required modules.
Switch CSV format to one event per row (fields: id, event_type, payload, delay_ms) and update storage functions accordingly. save_macro_to_csv now writes each MacroEvent on its own line with JSON-encoded payload; load_macros_from_csv reconstructs events and derives the macro name from the file stem, returning a single Macro. In the UI (app.py) macro naming no longer prompts the user: save/load derive the macro name from the filename and logging was updated; obsolete multi-macro selection logic was removed. Note: this changes the on-disk CSV schema and is not compatible with the previous single-row JSON "events" format.
Player now accepts an optional on_completion callback (CompletionFn) and invokes it when playback finishes naturally (it is skipped if playback was stopped manually). The App passes an _on_playback_complete handler that dispatches stop_playback to the Tk main thread via after(0). A "Playback completed" log message is emitted before the callback; docstrings and types were added to reflect the change.
Remove unused simpledialog import from tkinter in app.py and reformat the Player.__init__ signature in player.py to a multi-line layout for readability/PEP8 compliance. These are style-only changes and do not alter runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the build system and macro storage logic for better cross-platform compatibility, more robust macro file handling, and improved playback lifecycle management. The highlights include a new manylinux-based build process for Linux, updates to the macro CSV format, and enhancements to the playback completion flow in the app.
Build system improvements:
build-manylinux.shscript to build Linux binaries in a manylinux container, including custom Python 3.14 installation and environment setup for compatibility and portability.ci.ymlandrelease.yml) to use the manylinux build process for Linux, and clarified steps for Windows, ensuring platform-specific dependency installation and builds. [1] [2]build.sh(Linux/macOS) andbuild.ps1(Windows) to explicitly include hidden imports for pynput backends, improving cross-platform support for keyboard and mouse event handling. [1] [2]Macro CSV storage refactor:
id,event_type,payload, anddelay_ms, and the macro name is derived from the filename rather than stored in the file. This simplifies macro file handling and improves clarity. [1] [2]storage.pyandapp.pyto align with the new format, removing interactive macro selection on load and always using the filename as the macro name. [1] [2] [3]Playback lifecycle and UI enhancements:
on_completioncallback to thePlayerclass, allowing the app to respond when playback finishes naturally (not manually stopped), and wired this to update the UI appropriately. [1] Fdef4e65L50R50, [2] [3]Other updates:
These changes collectively improve the reliability and portability of the build process, make macro files easier to work with, and ensure the UI stays in sync with playback state.