fix: include encrypted value in create --secret payload #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reforge create --secretnot including the encrypted value in the API payloadmapConfigValueToDtoto shared utility to prevent similar bugsset-default --secretto interactive menu for consistencyProblem
When using
reforge create --secret, the POST payload was missing thevaluefield:{ "value": { "type": "string", "confidential": true, "decryptWith": "reforge.secrets.encryption.key" } }The
valuefield containing the encrypted string was not being included.Solution
makeConfidentialValuereturns{value: encrypted, confidential, decryptWith}mapConfigValueToDtowasn't checking forconfigValue.valuecreateandset-defaultuse the same code pathTest plan
reforge create test.secret --type=string --value=test --secret🤖 Generated with Claude Code