feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context#860
Open
RenzoPrats wants to merge 8 commits intofeat/AB#80876-add-geographic-context-in-pagefrom
Conversation
RenzoPrats
changed the title
15 tasks
….com-relief:ReliefApplications/ems-backend into feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
fix: avoid the possibility of saving both region and country properties as they are mutually exclusive
refactor: context property build for the dashboard object in order to delete all unecessary lines of code
unai-reliefapp
approved these changes
Dec 12, 2023
| if (get(item, 'record')) { | ||
| uniqueEntries.add((item as any).record.toString()); | ||
|
|
||
| if ('geographic' in entry && 'geography') { |
Contributor
There was a problem hiding this comment.
Hi @RenzoPrats , this is the only thing that I don't get, why set && 'geography' in the condition, that is always true right? Is it necessary?
Besides that looks good to me 👍
Contributor
Author
There was a problem hiding this comment.
Hi @unai-reliefapp, indeed it was useless I think I misspelled it, it's already fixed, thank you!
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feat: Added logic to create/edit and load page with a specific geographic context.
Useful links
ticket
frontend
Type of change
How Has This Been Tested?
It has been tested setting up a geographic context and verifying if it's created a dashboard when we don't have one for this context and if it's loaded when we have one for this context, also tested with resource/referenceData context at the same time that geographic is enabled.
Screenshots
Checklist:
( * == Mandatory )