Open
Conversation
…aired a logic bug in tagbox widget
MwanPygmay
approved these changes
Sep 27, 2023
Contributor
MwanPygmay
left a comment
There was a problem hiding this comment.
- As suggested by Nathan in above comment, added support in grids, and in summary cards: mimicked behavior of users questions.
- Repaired a bug regarding tagbox widget linked to one of my previous tickets (people tagbox would raise an error).
People question should work fine now.
19 tasks
…ion # Conflicts: # libs/shared/src/lib/survey/init.ts
Contributor
|
Collaborator
|
request to do for pagination: query { |
Collaborator
|
putting as draft this one A few things to change:
I'll assign you the ticket on devops |
Contributor
|
Matthis-M-ReliefApps
suggested changes
May 16, 2024
Contributor
Matthis-M-ReliefApps
left a comment
There was a problem hiding this comment.
A few things to double-check but look overall fine
libs/shared/src/lib/components/ui/core-grid/grid/grid.component.html
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
libs/shared/src/lib/survey/components/people-select/people-select.component.ts
Outdated
Show resolved
Hide resolved
Matthis-M-ReliefApps
approved these changes
May 17, 2024
Contributor
Matthis-M-ReliefApps
left a comment
There was a problem hiding this comment.
Another great PR from the GOAT Matthieu
Collaborator
|
@Matthis-M-ReliefApps @MwanPygmay most of it is working as expected, but I still see one issue 😅 the charts are not working:
We should see similar data than the one we see in other widgets |
Contributor
|
Still to be done:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This creates a dropdown with multiple selections, that allows to search for users
Useful links
Type of change
Please delete options that are not relevant.
Screenshots
Screen.Recording.2023-10-09.at.09.09.28.mov
Checklist:
( * == Mandatory )