Fix/ab#81892 method for calc in utils parser#2183
Open
RenzoPrats wants to merge 10 commits intobetafrom
Open
Conversation
Contributor
|
@AntoineRelief is there the option were this values could be placed inside any other element besides span elements? If that the case a little modification should be done in the regex. |
TaiKamilla
approved these changes
Dec 19, 2023
Contributor
TaiKamilla
left a comment
There was a problem hiding this comment.
This works as intended
The only thing is that maybe is some scenario’s it might be that there is nested tags
and will only get the first span
… # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed: Method for calc in utils parser is removing some span in the code.
Useful links
ticket
Type of change
How Has This Been Tested?
It has been tested creating a text widget and putting some {{calc. operations inside the editor using some data to these operations that have style applied to the layout of it, and also testing if others span in the content is not being removed.
Screenshots
Checklist:
( * == Mandatory )