Skip to content

feat/HIT-343-Add-triggers-for-email-notifications#59

Closed
estelafs wants to merge 15 commits intonext-oortfrom
feat/HIT-343-Add-triggers-for-email-notifications
Closed

feat/HIT-343-Add-triggers-for-email-notifications#59
estelafs wants to merge 15 commits intonext-oortfrom
feat/HIT-343-Add-triggers-for-email-notifications

Conversation

@estelafs
Copy link
Contributor

@estelafs estelafs commented Jul 31, 2024

Description

  • Update Resource model and type: to save triggersFilters data and to return to the front-end the ccustomNotifications data of a given application
  • Update CustomNotification model and type: to save the properties onRecordCreation, onRecordUpdate and applicationTrigger, redirect and filter. 'schedule' property is now optinal.

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs marked this pull request as ready for review August 23, 2024 12:59
@AntoineRelief AntoineRelief deleted the feat/HIT-343-Add-triggers-for-email-notifications branch November 17, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants