Skip to content

feat/HIT-350-multiselect-dropdown-and-users-question-show-all-the-options-selected#109

Open
estelafs wants to merge 1 commit intonext-oortfrom
feat/HIT-350-multiselect-dropdown-and-users-question-show-all-the-options-selected
Open

feat/HIT-350-multiselect-dropdown-and-users-question-show-all-the-options-selected#109
estelafs wants to merge 1 commit intonext-oortfrom
feat/HIT-350-multiselect-dropdown-and-users-question-show-all-the-options-selected

Conversation

@estelafs
Copy link
Contributor

Description

Updated SelectMenuComponent: added input property displayAllOptions, if true the setDisplayTriggerText method will try to display all selected options, or the max as possible

Also updated tagbox-widget, removing code that always compacted the options selected when more than 1 were selected

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

As described in the screenshots attached

Screenshots

multiselect-dropdown.webm

user1

user2.webm

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement New feature or request label Jul 29, 2024
@estelafs estelafs self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants