Skip to content

feat: improve savings_goals test coverage and fix contract compilation#218

Merged
Baskarayelu merged 5 commits intoRemitwise-Org:mainfrom
codeZe-us:main
Feb 26, 2026
Merged

feat: improve savings_goals test coverage and fix contract compilation#218
Baskarayelu merged 5 commits intoRemitwise-Org:mainfrom
codeZe-us:main

Conversation

@codeZe-us
Copy link
Contributor

This PR implements test coverage for the withdraw_from_goal function and resolves several syntax, ownership, and redundant code issues in the savings_goals contract.


Changes

Added 7 new test cases for withdraw_from_goal covering:

  • ✅ Success scenarios
  • ✅ Insufficient balance
  • ✅ Locked goals
  • ✅ Unauthorized callers
  • ✅ Zero amounts
  • ✅ Nonexistent goals

Checklist

  • Tests added / updated
  • All existing tests pass
  • No new compiler warnings

closes #63

Screenshot 2026-02-19 222138

@codeZe-us
Copy link
Contributor Author

codeZe-us commented Feb 25, 2026

@Baskarayelu please merge.

@Baskarayelu
Copy link
Contributor

resolve the conflicts

@Baskarayelu
Copy link
Contributor

@codeZe-us please resolve the conflicts

@codeZe-us
Copy link
Contributor Author

codeZe-us commented Feb 25, 2026

@Baskarayelu i told you to merge this PR you refused. I closed the previous PR to open this after fixing conflicts so you can merge, you think it is easy to resolve conflicts constantly and make sure the code build without errors? This is the last time i will fix this conflict, if i see anymore conflict i will close this task and you can assign this to someone else.

@Baskarayelu
Copy link
Contributor

please resolve the conflicts

@Baskarayelu Baskarayelu merged commit 90eb2a8 into Remitwise-Org:main Feb 26, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Tests for Savings Goals withdraw_from_goal

2 participants