test(insurance): add zero/negative amount tests for create_policy (#76)#239
Open
tusharshah21 wants to merge 7 commits intoRemitwise-Org:mainfrom
Open
test(insurance): add zero/negative amount tests for create_policy (#76)#239tusharshah21 wants to merge 7 commits intoRemitwise-Org:mainfrom
tusharshah21 wants to merge 7 commits intoRemitwise-Org:mainfrom
Conversation
Contributor
|
@tusharshah21 Can you please resolve the conflicts? |
Author
|
done mate |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four explicit tests to
insurance's active test module to ensurecreate_policyalways rejects zero and negative values formonthly_premiumandcoverage_amount, satisfying issue #76.Changes
test_create_policy_zero_monthly_premium_panics— assertsmonthly_premium == 0is rejectedtest_create_policy_negative_monthly_premium_panics— assertsmonthly_premium < 0is rejectedtest_create_policy_zero_coverage_amount_panics— assertscoverage_amount == 0is rejectedtest_create_policy_negative_coverage_amount_panics— assertscoverage_amount < 0is rejectedScope
#[cfg(test)] mod test {}block inlib.rs— the only compiled test module for this crate.Verification
cargo testininsurance/passes all 25 tests (4 new + 21 existing) with 0 failures.Closes #76