Add static plugin initializer, add tree builder and tree node builder#10
Open
TheBrambleShark wants to merge 8 commits intoRemora:mainfrom
Open
Add static plugin initializer, add tree builder and tree node builder#10TheBrambleShark wants to merge 8 commits intoRemora:mainfrom
TheBrambleShark wants to merge 8 commits intoRemora:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
I'll get these resolved here shortly. Just wanted to get my code pushed. |
Attempted fix for blob issue.
This reverts commit c52663d.
Contributor
Author
|
@Nihlus Can you look into why the build is failing? It seems to be a pipeline issue. |
Contributor
|
I might not be Nihlus, but the reason for the CI failure is quite simple. |
Contributor
Author
|
Thanks Maze. I'll push an empty commit to kick off the checks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Fixes #2
Fixes #8
Adds a couple builder types which was necessary for caching the plugins before initializing them.
Additionally, the plugin service now no longer requires an
Option<PluginServiceOptions>(#2) and allows multiple plugins per assembly (#8). Currently it just adds all of the plugins from the assembly that match the provided predicate.