Fix .ToObject<T> throwing due to writer cache#32
Merged
Nihlus merged 2 commits intoRemora:mainfrom Sep 4, 2024
Merged
Conversation
Flushes the writer, which forces it to commit to the backing store - in the case of small JSON payloads, this causes an edge-case bug wherein the writer hasn't written anything, and thus this method will attempt to deserialize nothing, which throws an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit details - this bug was brought to my attention when attempting to monkey-patch Remora/Remora.Discord#338