Skip to content

Conversation

@alvaro-salort
Copy link

Implemented rsEvents for the Wiki service to allow real-time UI updates.
Removed legacy dummy code and unused tick events from 2012.
Matches the architecture of GxsChannels.

@defnax
Copy link
Contributor

defnax commented Jan 3, 2026

Hi you forget to commit the changes for p3wiki.h? it does not compile yet
ok i saw you removed not implemented features too

maybe for that needs a new pr next time for implement :)

/* Specific Service Data */
virtual bool getCollections(const uint32_t &token, std::vector<RsWikiCollection> &collections) override;
virtual bool getSnapshots(const uint32_t &token, std::vector<RsWikiSnapshot> &snapshots) override;
virtual bool getComments(const uint32_t &token, std::vector<RsWikiComment> &comments) override;

virtual bool getRelatedSnapshots(const uint32_t &token, std::vector<RsWikiSnapshot> &snapshots) override;

virtual bool submitCollection(uint32_t &token, RsWikiCollection &collection) override;
virtual bool submitSnapshot(uint32_t &token, RsWikiSnapshot &snapshot) override;
virtual bool submitComment(uint32_t &token, RsWikiComment &comment) override;

virtual bool updateCollection(uint32_t &token, RsWikiCollection &collection) override;

// Blocking Interfaces.
virtual bool createCollection(RsWikiCollection &collection) override;
virtual bool updateCollection(const RsWikiCollection &collection) override;
virtual bool getCollections(const std::list<RsGxsGroupId> groupIds, std::vector<RsWikiCollection> &groups) override;


/// @see RsWireEvent
SYSTEM = 24, // general system notifications
GXS_WIKI = 25,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For plugins the event system can allocate a event type dynamically, so that you do not need to modify rsevents.h. Use RsEvent::getDynamicEventType("some string") to get one. Instead of using RsEventTypes::GXS_WIKI, use rsEvents->getDynamicEventType("GXS_WIKI"); (or store the result in a variable).

@defnax
Copy link
Contributor

defnax commented Jan 3, 2026

@alvaro-salort we need keep licence header

@alvaro-salort alvaro-salort force-pushed the wiki-modernization-core branch from f9ea63d to e427710 Compare January 3, 2026 15:33
@JohannesKleine
Copy link
Contributor

git pull --rebase origin master does the trick without merging the remote, but it requires a force push after it, advantage it keeps the git tree easyer to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants