Skip to content

fix(PRO-1835): support bigint base addresses#45

Merged
robertmarsal merged 1 commit intomainfrom
feat-PRO-1835
Nov 17, 2025
Merged

fix(PRO-1835): support bigint base addresses#45
robertmarsal merged 1 commit intomainfrom
feat-PRO-1835

Conversation

@robertmarsal
Copy link
Contributor

No description provided.

@robertmarsal robertmarsal requested a review from a team as a code owner November 17, 2025 12:57
@linear
Copy link

linear bot commented Nov 17, 2025

PRO-1835 Update SQL query to be able to handle very large numbers for base address

Some of the linux kernel binaries have a very large base address and cause an sql error in the API

`"SELECT public.analysis.analysis_id, public.analysis.model_id, public.models.model_name, public.analysis.status, public.analysis.creation, public.analysis.analysis_scope, public.analysis.user_id = $1::INTEGER AS is_owner, public.binaries.binary_name, public.binaries.sha_256_hash, public.binaries.binary_size, public.binaries.binary_id, coalesce(CAST(CAST(public.binaries.symbols ->> $2::TEXT AS VARCHAR) AS BIGINT), $3::INTEGER) AS base_address, public.binaries.symbols -> $4::TEXT AS provided_boundaries, public.users.username 
FROM public.analysis LEFT OUTER JOIN public.binaries ON public.binaries.binary_id = public.analysis.binary_id LEFT OUTER JOIN public.users ON public.users.user_id = public.analysis.user_id JOIN public.models ON public.models.model_id = public.analysis.model_id 
WHERE analysis.analysis_scope = 'PUBLIC' AND public.analysis.active = true GROUP BY public.analysis.analysis_id, public.analysis.model_id, public.models.model_name, public.analysis.status, public.analysis.creation, public.analysis.analysis_scope, public.analysis.user_id, public.binaries.binary_name, public.binaries.sha_256_hash, public.binaries.binary_size, public.binaries.binary_id, public.users.username ORDER BY public.analysis.creation DESC 
 LIMIT $5::INTEGER OFFSET $6::INTEGER"

Causing

class 'asyncpg.exceptions.NumericValueOutOfRangeError'>: value "18446606429673488384" is out of range for type bigint

Update the API to support this. Please confirm the generated SDK will still work

@robertmarsal robertmarsal merged commit 8f7d9a5 into main Nov 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments