use offsetParent for correct position of children of statically positioned nodes#48
Open
Rich-Harris wants to merge 1 commit intomasterfrom
Open
use offsetParent for correct position of children of statically positioned nodes#48Rich-Harris wants to merge 1 commit intomasterfrom
Rich-Harris wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready for merge
Wild things start happening when you transform descendants of statically positioned nodes, because the absolute positioning (which is necessary to avoid insane layout glitches) is calculated on the wrong basis (
node.parentNoderather thannode.offsetParent). This fixes that, but it introduces another bug – if you have transformed nodes between the offset parent and the transformed node, the transforms aren't correctly applied.