OOP School Library: Add Person, Student, and Teacher Classes#1
OOP School Library: Add Person, Student, and Teacher Classes#1Ridwanullahi-code wants to merge 8 commits intomainfrom
Conversation
Ridwanullahi-code
commented
Mar 13, 2023
- Create class Person with the following:
- Create class Student with the following:
- Create class Teacher with the following:
Ismailco
left a comment
There was a problem hiding this comment.
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that uses an old README template kindly make sure to use the new one provided by microverse for more professional documentation
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
m05e5
left a comment
There was a problem hiding this comment.
**Hi @Ridwanullahi-code
You did great. Your project is complete! There is nothing else to say other than... it's time to merge it ![]()
Congratulations! 🎉

Highlights
✔️ Clean and well-organized code
✔️ No Linters error
✔️ Good PR description
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
m05e5
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.**