fix: default hourly cost quota should be unlimited (0.0), not $1.00#417
Open
f-liva wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix: default hourly cost quota should be unlimited (0.0), not $1.00#417f-liva wants to merge 1 commit intoRightNow-AI:mainfrom
f-liva wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
The ResourceQuota default set max_cost_per_hour_usd to 1.0 while daily and monthly were 0.0 (unlimited). This caused agents without explicit quota configuration to hit a hidden $1/hour cap. Also fixes apply_budget_defaults() which compared against the old hardcoded default value of 1.0. Fixes RightNow-AI#416 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourceQuota::default()max_cost_per_hour_usdfrom1.0to0.0(unlimited), consistent with daily and monthly defaultsapply_budget_defaults()inkernel.rswhich compared against the old hardcoded1.0sentinel valueProblem
When no quota is configured,
max_cost_per_hour_usddefaults to1.0whilemax_cost_per_day_usdandmax_cost_per_month_usddefault to0.0(unlimited). This creates a hidden $1/hour cap that blocks agents unexpectedly.Test plan
test_check_quota_zero_limit_skippedvalidates that0.0means no enforcementtest_record_and_check_quota_underandtest_check_quota_exceededset explicit values, unaffectedFixes #416
🤖 Generated with Claude Code