Fix wizard: use multi-line TOML strings for system_prompt#464
Open
citadelgrad wants to merge 2 commits intoRightNow-AI:mainfrom
Open
Fix wizard: use multi-line TOML strings for system_prompt#464citadelgrad wants to merge 2 commits intoRightNow-AI:mainfrom
citadelgrad wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
…rompt The spawn wizard used single-line TOML strings for system_prompt, which broke when the prompt contained newlines. Switch to multi-line basic strings (triple-quoted) matching the pattern already used in spawnBuiltin(). Fixes RightNow-AI#463
Tests cover the exact TOML format produced by the dashboard wizard's generateToml() function: multi-line prompts, embedded quotes, code blocks, single-line backward compat, and custom profile with capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateToml()in the dashboard spawn wizard to use TOML multi-line basic strings ("""...""") forsystem_promptinstead of single-line stringsspawnBuiltin()function already used multi-line strings correctly; this bringsgenerateToml()in lineFixes #463
Test plan
openfang-typescovering:cargo test -p openfang-types