Skip to content
This repository was archived by the owner on Jan 30, 2021. It is now read-only.

Comments

Build changelog for hockey/testflight release#113

Open
pauluhn wants to merge 2 commits intomasterfrom
feature/puhn/changelog
Open

Build changelog for hockey/testflight release#113
pauluhn wants to merge 2 commits intomasterfrom
feature/puhn/changelog

Conversation

@pauluhn
Copy link

@pauluhn pauluhn commented Dec 18, 2018

No description provided.

@raizlabs-oss-bot
Copy link

raizlabs-oss-bot commented Dec 18, 2018

Danger has errored

[!] Invalid Dangerfile file: �[31mSpecified derived data directory does not exist�[0m

 #  from PRODUCTNAME/Dangerfile:21
 #  -------------------------------------------
 #  
 >  xcov.report(
 #    workspace: "#{src_root}/PRODUCTNAME.xcworkspace",
 #  -------------------------------------------

Generated by 🚫 Danger

Copy link

@BrianKing-Pear BrianKing-Pear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I think you authored the change directly in the cookiecutter directory though. You want to do modifications in the PRODUCTNAME directory and then run generate_template.sh. This allows the template project to use Xcode, since you can't actually open the cookiecutter files in Xcode.

Also, the README has had trouble describing this process. If there's anything in the README that might make this clearer that would be great!

@pauluhn
Copy link
Author

pauluhn commented Dec 18, 2018

@BrianKing-Pear Haven't had a chance to deep dive into cookiecutter. Thanks for taking a look tho! I'll definitely take a closer look at the README and make those changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants