Skip to content
This repository was archived by the owner on Jan 30, 2021. It is now read-only.

Comments

Actionable Pod#116

Open
nevillco wants to merge 7 commits intomasterfrom
feature/Actionable-pod
Open

Actionable Pod#116
nevillco wants to merge 7 commits intomasterfrom
feature/Actionable-pod

Conversation

@nevillco
Copy link
Contributor

The Actionable pod is up on trunk. This PR integrates it.

  • Actionable.swifttemplate has been improved to handle things like varied access control and nested Actionable types
  • Now that it exists in a pod, you must import Actionable in files that use the protocol
  • Build phase has been cleaned up

@raizlabs-oss-bot
Copy link

raizlabs-oss-bot commented Feb 15, 2019

1 Warning
⚠️ Big PR
4 Messages
📖 Test Results
📖 Code Coverage: xcov
📖 Code Coverage: Slather
📖 Screenshots

Current coverage for Services.framework is 68.68%

No files affecting coverage found


Current coverage for debug-PRODUCTNAME.app is 1.86%

Files changed - -
SignInCoordinator.swift 0.00% 💀
AuthCoordinator.swift 0.00% 💀
OnboardingCoordinator.swift 0.00% 💀
Actionable+AutoConformance.swift 0.00% 💀
OnboardingPageViewController.swift 0.00% 💀

Powered by xcov

Generated by 🚫 Danger

@nevillco nevillco mentioned this pull request Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants