This repository was archived by the owner on Jan 30, 2021. It is now read-only.
Open
Conversation
Current coverage for Services.framework is
|
| Files changed | - | - |
|---|---|---|
| RequestProtocol.swift | 0.00% |
💀 |
| APIClient+PRODUCTNAME.swift | 0.00% |
💀 |
| APIEndpoint.swift | 25.00% |
🚫 |
| APIClient.swift | 66.67% |
|
| Alamofire+PRODUCTNAME.swift | 73.44% |
|
| APISerialization.swift | 74.29% |
|
| APIEndpoint+Logging.swift | 76.19% |
|
| OAuth.swift | 77.44% |
|
| APIValidation.swift | 86.67% |
✅ |
| APIEnvironment.swift | 100.00% |
✅ |
| Keychain+Codable.swift | 100.00% |
✅ |
| BuildType.swift | 100.00% |
✅ |
| APIError.swift | 100.00% |
✅ |
| Formatters.swift | 100.00% |
✅ |
| APIEndpoint+Codable.swift | 100.00% |
✅ |
Current coverage for debug-PRODUCTNAME.app is 0.78%
| Files changed | - | - |
|---|---|---|
| SignInCoordinator.swift | 0.00% |
💀 |
| OnboardingCoordinator.swift | 0.00% |
💀 |
| OnboardingPageViewController.swift | 0.00% |
💀 |
| InstabugConfiguration.swift | 0.00% |
💀 |
| LoggingConfiguration.swift | 0.00% |
💀 |
| StringStyle+PRODUCTNAME.swift | 0.00% |
💀 |
| DebugTextStyleViewController.swift | 0.00% |
💀 |
| TableDataSource.swift | 0.00% |
💀 |
| UIColor+Extensions.swift | 0.00% |
💀 |
| AuthCoordinator.swift | 0.00% |
💀 |
| OnboardingSamplePageViewController.swift | 0.00% |
💀 |
| ModalDismissBehavior.swift | 0.00% |
💀 |
| StatusBarConfiguration.swift | 0.00% |
💀 |
| SimpleTableCellItem.swift | 0.00% |
💀 |
| DebugMenuViewController.swift | 0.00% |
💀 |
| Appearance.swift | 0.00% |
💀 |
| ControlContainable.swift | 0.00% |
💀 |
| AnalyticsConfiguration.swift | 0.00% |
💀 |
| AppLifecycle.swift | 0.00% |
💀 |
| AnalyticsPageNames.swift | 0.00% |
💀 |
| Actionable.swift | 0.00% |
💀 |
| TableViewContainerCell.swift | 0.00% |
💀 |
| ContentTabBarViewController.swift | 0.00% |
💀 |
| ContentCoordinator.swift | 0.00% |
💀 |
| ViewRepresentable.swift | 0.00% |
💀 |
| ProcessInfo+Utilities.swift | 0.00% |
💀 |
| TableViewCellRepresentable.swift | 0.00% |
💀 |
| GoogleAnalytics.swift | 0.00% |
💀 |
| Analytics.swift | 0.00% |
💀 |
| TableSection.swift | 0.00% |
💀 |
| DebugMenu.swift | 0.00% |
💀 |
| TableCellItem.swift | 0.00% |
💀 |
| DebugMenuConfiguration.swift | 0.00% |
💀 |
| HideBackButtonTextBehavior.swift | 0.00% |
💀 |
| AppCoordinator.swift | 0.00% |
💀 |
| CrashlyticsConfiguration.swift | 0.00% |
💀 |
| AppDelegate.swift | 21.43% |
💀 |
| UserDefaults+Utilities.swift | 50.00% |
Powered by xcov
Generated by 🚫 Danger
Conflicts:
PRODUCTNAME/app/PRODUCTNAME/Resources/Color.swift
{{ cookiecutter.project_name | replace(' ', '') }}/app/{{ cookiecutter.project_name | replace(' ', '') }}/Resources/Color.swift
minimusic
changed the title
Contributor
Author
|
This has some merge conflict issues I'll fix and I might refactor with an example of using system colors when running on iOS 13 |
Contributor
|
@minimusic what’s the case for using separate asset catalogs for colors and images? I thought dark mode colors are just silently ignored on iOS < 13? |
Contributor
Author
|
@ZevEisenberg You CAN just mix all colors and images in the single main asset catalog, and it will function. The main advantage was keeping them grouped, and when exporting from Zeplin you can choose which asset catalog to target. I'm open to other options! We tried making a "Colors" folder in the main catalog, but Zeplin doesn't know about it so new colors needed to be manually dragged in (didn't test with SwiftGen, but that should find colors in a folder). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all colors into new
Colors.xcassetscatalog. If built under iOS 13 SDK, fully supports dark mode. Once we are ready to force building under iOS 13 SDK, we can add a mechanism to opt for using new system colors if available, but for this PR I'm keeping project buildable on iOS 12 so we can merge now.