Initial AppCenter Transition by eliotw1 · Pull Request #155 · Rightpoint/ios-template

eliotw1 · 2019-11-01T22:59:29Z

No description provided.

eliotw1 · 2019-11-01T22:59:47Z

This is WIP, at this point.

eliotw1 · 2019-11-01T23:00:41Z

What else is missing from this setup?

raizlabs-oss-bot · 2019-11-01T23:03:24Z

	1 Error
🚫	Tests have failed, see below for more information.

	3 Warnings
⚠️	PR is classed as Work in Progress
⚠️	Big PR
⚠️	Please provide a summary in the Pull Request description

	4 Messages
📖	Test Results
📖	Code Coverage: xcov
📖	Code Coverage: Slather
📖	Screenshots in progress…

Current coverage for Services.framework is `63.21%`

Files changed	-	-
RequestProtocol.swift	`0.00%`	💀
APIError.swift	`0.00%`	💀
APIEndpoint.swift	`25.00%`	🚫
APISerialization.swift	`64.29%`	⚠️
APIClient.swift	`66.67%`	⚠️
OAuth.swift	`72.31%`	⚠️
APIEndpoint+Logging.swift	`76.19%`	⚠️
APIValidation.swift	`86.67%`	✅
Formatters.swift	`100.00%`	✅
Keychain+Codable.swift	`100.00%`	✅
BuildType.swift	`100.00%`	✅
APIEndpoint+Codable.swift	`100.00%`	✅
APIEnvironment.swift	`100.00%`	✅

Current coverage for debug-PRODUCTNAME.app is `0.77%`

Files changed	-	-
SignInCoordinator.swift	`0.00%`	💀
InstabugConfiguration.swift	`0.00%`	💀
OnboardingCoordinator.swift	`0.00%`	💀
OnboardingPageViewController.swift	`0.00%`	💀
LoggingConfiguration.swift	`0.00%`	💀
FirebaseAnalytics.swift	`0.00%`	💀
DebugTextStyleViewController.swift	`0.00%`	💀
AuthCoordinator.swift	`0.00%`	💀
TableDataSource.swift	`0.00%`	💀
UIColor+Extensions.swift	`0.00%`	💀
OnboardingSamplePageViewController.swift	`0.00%`	💀
ModalDismissBehavior.swift	`0.00%`	💀
StatusBarConfiguration.swift	`0.00%`	💀
SimpleTableCellItem.swift	`0.00%`	💀
Appearance.swift	`0.00%`	💀
DebugMenuViewController.swift	`0.00%`	💀
AnalyticsConfiguration.swift	`0.00%`	💀
ControlContainable.swift	`0.00%`	💀
AppLifecycle.swift	`0.00%`	💀
AnalyticsPageNames.swift	`0.00%`	💀
Actionable.swift	`0.00%`	💀
TableViewContainerCell.swift	`0.00%`	💀
AppCenterConfiguration.swift	`0.00%`	💀
ContentTabBarViewController.swift	`0.00%`	💀
ContentCoordinator.swift	`0.00%`	💀
ViewRepresentable.swift	`0.00%`	💀
ProcessInfo+Utilities.swift	`0.00%`	💀
TableViewCellRepresentable.swift	`0.00%`	💀
Analytics.swift	`0.00%`	💀
TableSection.swift	`0.00%`	💀
DebugMenu.swift	`0.00%`	💀
TableCellItem.swift	`0.00%`	💀
DebugMenuConfiguration.swift	`0.00%`	💀
HideBackButtonTextBehavior.swift	`0.00%`	💀
AppCoordinator.swift	`0.00%`	💀
CrashlyticsConfiguration.swift	`0.00%`	💀
AppDelegate.swift	`17.14%`	💀
UserDefaults+Utilities.swift	`50.00%`	⚠️

Powered by xcov

Tests:

Classname	Name
PRODUCTNAMETests.APIClientTests	testAuthenticatedRequestWithCredentials
PRODUCTNAMETests.APIClientTests	testAuthenticatedRequestWithNoCredentials

Generated by 🚫 Danger

eliotw1 · 2019-11-01T23:23:03Z

PRODUCTNAME/README.md


 [circle-ci]: https://circleci.com/gh/Rightpoint/{{ cookiecutter.project_name }}-ios
 [JIRA]: https://raizlabs.atlassian.net/secure/RapidBoard.jspa?projectKey={{ cookiecutter.jira_key }}
-[sprint-hockey]: https://rink.hockeyapp.net/apps/ZZHOCKEY_SPRINT_IDZZ


Seems like the structure of these links won't play well for AppCenter :(

is there a reason this format won't work?

We'll need an account (user) in the url, which may vary per project.

Analytics Tweak CI Fixes

ahtierney

Looking great! Just jotting down a few preliminary notes here.

ahtierney · 2019-11-11T23:50:00Z

PRODUCTNAME/README.md


 ## Development Process
-All stories and bugs are tracked in [JIRA][]. Development occurs on branches that are tested with the `test` fastlane task once a PR is created. The PR is reviewed and then merged into the `develop` branch. This triggers the `develop` fastlane task which distributes a build to the [develop][develop-hockey] hockey app for testing and PO approval. At the end of a sprint, a `sprint-X` tag is manually created which triggers the `sprint` fastlane task which distributes a build to the [sprint][sprint-hockey] hockey app.
+All stories and bugs are tracked in [JIRA][]. Development occurs on branches that are tested with the `test` fastlane task once a PR is created. The PR is reviewed and then merged into the `develop` branch. This triggers the `develop` fastlane task which distributes a build to the [develop][develop-appcenter] hockey app for testing and PO approval. At the end of a sprint, a `sprint-X` tag is manually created which triggers the `sprint` fastlane task which distributes a build to the [sprint][sprint-appcenter] hockey app.


probably worth doing a global find+replace for hockey – still hanging out in here.

ahtierney · 2019-11-11T23:50:47Z

PRODUCTNAME/README.md


 [circle-ci]: https://circleci.com/gh/Rightpoint/{{ cookiecutter.project_name }}-ios
 [JIRA]: https://raizlabs.atlassian.net/secure/RapidBoard.jspa?projectKey={{ cookiecutter.jira_key }}
-[sprint-hockey]: https://rink.hockeyapp.net/apps/ZZHOCKEY_SPRINT_IDZZ


is there a reason this format won't work?

ahtierney · 2019-11-11T23:53:28Z

PRODUCTNAME/app/PRODUCTNAME/Application/AppLifecycle/Analytics/FirebaseAnalytics.swift

+class FirebaseAnalytics {
+
+    static let shared: FirebaseAnalytics = { () -> FirebaseAnalytics in
+        let sh = FirebaseAnalytics()


#pp shared – also 2 letter variable might trip a linter.

ahtierney · 2019-11-11T23:57:48Z

PRODUCTNAME/app/PRODUCTNAME/Application/AppLifecycle/AnalyticsConfiguration.swift

 //  Copyright © THISYEAR ORGANIZATION. All rights reserved.
 //

+import Firebase


#? curios why firebase moved up here? maybe all the configuration code can be contained internally in the configure method?

ahtierney · 2019-11-12T00:02:40Z

PRODUCTNAME/app/PRODUCTNAME/Application/AppLifecycle/AnalyticsConfiguration.swift

+        var filePath: String?
+        switch BuildType.active {
+        case .debug:
+            filePath = Bundle.main.path(forResource: "GoogleService-Info-Debug", ofType: "plist")


#pp

guard let filePath = Bundle.main.path(forResource: BuildType.active.googleAnalyticsConfigName, ofType: "plist") else { Log.error("Firebase configuration not found!")

ahtierney · 2019-11-12T00:24:00Z

PRODUCTNAME/app/fastlane/Pluginfile

+#
+# Ensure this file is checked in to source control!
+
+gem 'fastlane-plugin-install_provisioning_profiles'


#?/#req we shouldn't be using this plugin any longer unless I'm missing something.

ahtierney · 2019-11-12T00:42:49Z

PRODUCTNAME/app/fastlane/Fastfile

 ENV['FL_HOCKEY_NOTIFY'] = '0'

 DERIVED_DATA_PATH = "#{ENV['RZ_TEST_REPORTS']}/derived_data"
-TEST_SCHEME = "debug-PRODUCTNAME"
+TEST_SCHEME = "debug-{{ cookiecutter.project_name | replace(' ', '') }}"


#pp this is a little brittle to have sitting everywhere, I'd prefer to have it be some sort of global constant (thought I recognize the preprocessing step isn't ideal).

chrisballinger · 2019-11-12T19:31:23Z

PRODUCTNAME/app/fastlane/Fastfile

 # MATCH_PASSWORD
 # SLACK_URL - set the hook URL in the CircleCI environment

 ENV['RZ_ARTIFACTS'] ||= ENV['CIRCLE_ARTIFACTS'] || './build'
 ENV['RZ_TEST_REPORTS'] ||= ENV['CIRCLE_TEST_REPORTS'] || './build'
 ENV['FASTLANE_XCODE_LIST_TIMEOUT'] = '120'
 ENV['CI_BUILD'] = 'yes'
-ENV['GYM_OUTPUT_NAME'] = 'PRODUCTNAME'
-ENV['FL_HOCKEY_IPA'] = "#{ENV['RZ_ARTIFACTS']}/#{ENV['GYM_OUTPUT_NAME']}.ipa"
+ENV['GYM_OUTPUT_NAME'] = '{{ cookiecutter.project_name | replace(' ', '') }}'


Anything in PRODUCTNAME shouldn't have {{ cookiecutter.project_name | replace(' ', '') }}, that is only for things in the {{ cookiecutter.project_name | replace(' ', '') }} directory.

PRODUCTNAME is replaced with {{ cookiecutter.project_name | replace(' ', '') }} in the generate_template.sh step

chrisballinger · 2019-11-13T01:30:49Z

generate_template.sh

 replace "LEADDEVELOPER" "{{ cookiecutter.lead_dev }}"
 replace "APPLEID" "{{ cookiecutter.apple_id }}"
-replace "com.raizlabs.PRODUCTNAME" "{{ cookiecutter.bundle_identifier }}"
+replace "com.rightpoint.PRODUCTNAME" "{{ cookiecutter.bundle_identifier }}"


chrisballinger · 2019-11-13T01:33:37Z

...ter.project_name | replace(' ', '') }}/Application/AppLifecycle/AnalyticsConfiguration.swift

-//  Created by {{ cookiecutter.lead_dev }} on {% now 'utc', '%D' %}.
-//  Copyright © {% now 'utc', '%Y' %} {{ cookiecutter.company_name }}. All rights reserved.
+//  Created by {{ cookiecutter.lead_dev }} on TODAYSDATE.
+//  Copyright © THISYEAR {{ cookiecutter.company_name }}. All rights reserved.


@eliotw1 Is this TODAYSDATE and THISYEAR change intentional? It seems to be on a large majority of the files in this PR, which makes me think its a template regeneration or copy-paste error

this is a template gen issue.

eliotw1 added the WIP label Nov 1, 2019

eliotw1 requested a review from chrisballinger November 1, 2019 22:59

eliotw1 force-pushed the issues/eliotw1/143-AppCenter branch from 59a128a to 8b78045 Compare November 1, 2019 23:22

eliotw1 commented Nov 1, 2019

View reviewed changes

eliotw1 force-pushed the issues/eliotw1/143-AppCenter branch 5 times, most recently from 7ac3f28 to 78c5706 Compare November 6, 2019 17:40

eliotw1 added 2 commits November 6, 2019 14:04

Initial AppCenter Transition

9ffd093

Analytics Tweak CI Fixes

Fix Build error

623e9a6

eliotw1 force-pushed the issues/eliotw1/143-AppCenter branch from b35f876 to 623e9a6 Compare November 6, 2019 22:06

ahtierney reviewed Nov 12, 2019

View reviewed changes

chrisballinger reviewed Nov 12, 2019

View reviewed changes

eliotw1 added 2 commits November 12, 2019 12:38

Fix Builds

859e57a

Rework Cookiecutter.json

58b53d7

eliotw1 force-pushed the issues/eliotw1/143-AppCenter branch from 3d07331 to 58b53d7 Compare November 13, 2019 00:55

chrisballinger reviewed Nov 13, 2019

View reviewed changes

Comments

Conversation

eliotw1 commented Nov 1, 2019

Uh oh!

eliotw1 commented Nov 1, 2019

Uh oh!

eliotw1 commented Nov 1, 2019

Uh oh!

raizlabs-oss-bot commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage for Services.framework is 63.21%

Current coverage for debug-PRODUCTNAME.app is 0.77%

Tests:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahtierney left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raizlabs-oss-bot commented Nov 1, 2019 •

edited

Loading

Current coverage for Services.framework is `63.21%`

Current coverage for debug-PRODUCTNAME.app is `0.77%`