Make the UpdateRecevier not wait for each handler#4
Draft
XSilverTH wants to merge 3 commits intoRikitav:masterfrom
Draft
Make the UpdateRecevier not wait for each handler#4XSilverTH wants to merge 3 commits intoRikitav:masterfrom
XSilverTH wants to merge 3 commits intoRikitav:masterfrom
Conversation
Owner
|
The receiver is not a component that is responsible for the execution of handlers. This is handled by IUpdateRouter, the standard implementation uses a pool to manage the life of handlers. For more info check : https://github.com/Rikitav/Telegrator/blob/master/Telegrator/Polling/UpdateRouter.cs |
Author
|
i still don't know if executing handlers synchronously was intended behaviour or not |
…iver to UpdateHandlersPool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea if awaiting each handler was intended behavior but it seems wrong to me to freeze the whole bot just because a command is taking long to execute