Skip to content

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Feb 9, 2026

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1739

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Updated CI/CD build environment to macOS 26 (from macOS 15)
    • Updated Xcode version to 26.2.0 for iOS builds
    • Added iOS design compatibility configuration setting

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

The pull request updates iOS CI/CD infrastructure to support iOS 26, incrementing macOS runners from version 15 to 26 across multiple workflows, updating Xcode versions to 26.2.0 in action configurations, and adding a UIDesignRequiresCompatibility key to the iOS app's configuration file.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Runners
.github/workflows/build-ios.yml, .github/workflows/build-official-ios.yml, .github/workflows/e2e-build-ios.yml
Updated macOS runner version from 15 to 26 for build-ios and upload-ios jobs across three workflows.
GitHub Actions Xcode Setup
.github/actions/build-ios/action.yml, .github/actions/upload-ios/action.yml
Updated Xcode versions in setup-xcode steps (16.4→26.2.0 and 16.2→26.2.0 respectively) to support iOS 26 build environment.
iOS App Configuration
ios/RocketChatRN/Info.plist
Added UIDesignRequiresCompatibility boolean key set to true for iOS 26 compatibility requirements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With iOS twenty-six now on the rise,
We hop and bounce to modernize,
New Xcode versions, runners fleet,
macOS twenty-six is quite a treat,
Compatibility keys make our build complete! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive The PR updates CI/build configurations and adds UIDesignRequiresCompatibility but does not include component reviews/fixes mentioned in CORE-1739 (Switch, header buttons), making it unclear if this is intentional scope limitation. Clarify whether component updates are deferred to separate PRs or if they should be included in this changeset to fully address CORE-1739.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: bumping the iOS deployment target to iOS 26, which aligns with the primary objective of the pull request.
Linked Issues check ✅ Passed The PR successfully addresses CORE-1739's coding objectives: CI updated to build with iOS 26 SDK (macOS 26, Xcode 26.2.0) and UIDesignRequiresCompatibility added for compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
.github/workflows/e2e-build-ios.yml (1)

34-37: Xcode version is hardcoded in this workflow separately from the reusable actions.

The Xcode version 26.2.0 is set directly here (Line 37) as well as in .github/actions/build-ios/action.yml (Line 56) and .github/actions/upload-ios/action.yml (Line 94) — three independent places to maintain. Consider extracting this into a workflow-level environment variable or a shared configuration to reduce the risk of version drift in future updates.

.github/actions/build-ios/action.yml (1)

58-62: Ruby 2.7.7 is end-of-life and incompatible with macOS 26.

Ruby 2.7 reached end-of-life on March 31, 2023. This version is used across multiple CI workflows (iOS and Android actions) and is incompatible with the system libraries in macOS 26 (released September 2025), which your iOS builds now use (macos-26). While this is a pre-existing concern, upgrading to Ruby 3.1+ in a follow-up would prevent potential build failures on current runners.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 294fbb2 and 2969a55.

📒 Files selected for processing (6)
  • .github/actions/build-ios/action.yml
  • .github/actions/upload-ios/action.yml
  • .github/workflows/build-ios.yml
  • .github/workflows/build-official-ios.yml
  • .github/workflows/e2e-build-ios.yml
  • ios/RocketChatRN/Info.plist
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: E2E Run iOS (6) / ios-test
🔇 Additional comments (6)
.github/actions/build-ios/action.yml (1)

56-56: Xcode version bump looks correct.

Xcode 26.2 release notes confirm this version exists and is available from Apple. It's already available on macOS-26 runners.

Note that Xcode 26.3 Release Candidate is already out as of early February 2026 — you may want to bump to 26.3 once it's GA, but 26.2.0 is fine for now.

.github/actions/upload-ios/action.yml (1)

94-94: Xcode version update is consistent with the build action.

Aligns with the build-ios action's Xcode 26.2.0 update.

.github/workflows/build-ios.yml (1)

25-25: macos-26 runners are still in public beta — expect potential instability.

The image is marked as beta for now. It means some software can be unstable on the new platform. Also, there could be queueing issues as the capacity will be balanced only throughout the next weeks. Beta and Deprecated Images are provided "as-is", "with all faults" and "as available" and are excluded from the service level agreement and warranty. Beta Images may not be covered by customer support.

This is acceptable given the April 2026 App Store deadline (starting April 2026, apps uploaded to App Store Connect need to be built with the iOS 26 SDK or later), but be prepared for occasional queueing delays or flaky runs until the runner image goes GA.

Also applies to: 65-65

.github/workflows/e2e-build-ios.yml (1)

25-25: Runner update to macos-26 is consistent with the other workflows.

Same beta-runner caveat applies as noted in build-ios.yml.

.github/workflows/build-official-ios.yml (1)

25-25: Runner updates are consistent with the experimental workflow.

Same macos-26 beta-runner considerations apply. No additional concerns for this file.

Also applies to: 75-75

ios/RocketChatRN/Info.plist (1)

111-112: Correct use of UIDesignRequiresCompatibility as a transitional measure.

Setting UIDesignRequiresCompatibility to true in Info.plist opts the app out of the new Liquid Glass design. This flag is intended for temporary compatibility during SDK transitions while you address UI component issues. Apple plans to remove this option in a future Xcode release, making Liquid Glass adoption mandatory eventually.

This is a reasonable approach to unblock the iOS 26 SDK migration while the team addresses UI component incompatibilities (Switch, header buttons per CORE-1739). Ensure this change is tracked for removal as a follow-up task to avoid shipping it long-term. The flag is appropriately scoped to the main app only; the NotificationService extension doesn't require it (background-only), and the ShareRocketChatRN share extension has minimal UI without the problematic components.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing February 9, 2026 17:33 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 9, 2026 17:36 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 9, 2026 17:36 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build February 9, 2026 17:36 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing February 9, 2026 17:55 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build February 9, 2026 17:58 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 9, 2026 17:58 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 9, 2026 17:58 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 9, 2026 19:12 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 9, 2026 19:12 — with GitHub Actions Error
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

iOS Build Available

Rocket.Chat Experimental 4.70.0.108241

@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing February 9, 2026 20:35 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 9, 2026 20:38 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build February 9, 2026 20:38 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 9, 2026 20:38 — with GitHub Actions Error
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

iOS Build Available

Rocket.Chat Experimental 4.70.0.108245

@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing February 10, 2026 13:58 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 10, 2026 14:01 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build February 10, 2026 14:01 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 deployed to experimental_ios_build February 10, 2026 14:01 — with GitHub Actions Active
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 10, 2026 14:30 — with GitHub Actions Error
@github-actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.70.0.108254

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTg4jw5R22TnfFeqS9IYBX-fQwUttGB2-gphPmeVnRMZZiv4xIMjxkDtdmRsceGFrIYIJfJsNMvPXABISBp

@github-actions
Copy link

iOS Build Available

Rocket.Chat Experimental 4.70.0.108255

@Rohit3523 Rohit3523 marked this pull request as ready for review February 10, 2026 16:04
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 10, 2026 16:56 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 10, 2026 16:56 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 10, 2026 18:55 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 10, 2026 18:55 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 11, 2026 05:05 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 11, 2026 05:05 — with GitHub Actions Error
@Rohit3523 Rohit3523 requested a deployment to experimental_android_build February 11, 2026 20:39 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_ios_build February 11, 2026 20:39 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_android_build February 11, 2026 20:39 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants