regression(ABAC): Missing abac section in team info

[MartinSchoeler]

Proposed changes (including videos or screenshots)

Issue(s)

ABAC-104

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• New Features
  • Added a new information section to the Teams Info panel displaying additional access control details and management options.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 22d5d8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR adds a new RoomInfoABACSection component to the TeamsInfo view by importing it and rendering it within the InfoPanelSection. The component is displayed after RetentionPolicyCallout with no changes to existing control flow or function signatures.

Changes

Cohort / File(s)	Change Summary
ABAC Info Section Addition apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx	Imports RoomInfoABACSection component and renders it within TeamsInfo InfoPanelSection alongside existing elements

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file change with straightforward component import and rendering
• No logic modifications or control flow alterations
• Verify component integration and proper placement within the InfoPanelSection

Possibly related PRs

• chore: ABAC Attributes room info view #37484 — Introduces RoomInfoABACSection component usage across multiple contextual bar views; this PR applies the same component pattern to TeamsInfo
• chore: Move InfoPanel component to ui-client package #37701 — Also modifies TeamsInfo.tsx; may have related InfoPanel or layout changes
• chore: add new icons to abac rooms #37424 — Updates ABAC UI surface (icon logic and header tags); complements this PR's ABAC attribute display additions

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• tassoevan
• dougfabris

Poem

🐰 A section hops into place,
ABAC attributes find their space,
Team info panels now complete,
With contextual bars, the view's so neat!
✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly identifies the main change: restoring a missing ABAC section in team info that was regressed.
Linked Issues check	✅ Passed	The PR adds RoomInfoABACSection component to TeamsInfo, directly addressing the missing ABAC attributes requirement in ABAC-104.
Out of Scope Changes check	✅ Passed	The changes are narrowly scoped to adding the ABAC section component in TeamsInfo, with no extraneous modifications beyond this objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch regression/abac-team-info

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b9aab8 and d7d35f9.

📒 Files selected for processing (1)

• apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx

🧠 Learnings (2)

📓 Common learnings

Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37557
File: apps/meteor/client/views/admin/ABAC/AdminABACRooms.tsx:115-116
Timestamp: 2025-11-27T17:56:26.050Z
Learning: In Rocket.Chat, the GET /v1/abac/rooms endpoint (implemented in ee/packages/abac/src/index.ts) only returns rooms where abacAttributes exists and is not an empty array (query: { abacAttributes: { $exists: true, $ne: [] } }). Therefore, in components consuming this endpoint (like AdminABACRooms.tsx), room.abacAttributes is guaranteed to be defined for all returned rooms, and optional chaining before calling array methods like .join() is sufficient without additional null coalescing.

📚 Learning: 2025-11-27T17:56:26.050Z

Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37557
File: apps/meteor/client/views/admin/ABAC/AdminABACRooms.tsx:115-116
Timestamp: 2025-11-27T17:56:26.050Z
Learning: In Rocket.Chat, the GET /v1/abac/rooms endpoint (implemented in ee/packages/abac/src/index.ts) only returns rooms where abacAttributes exists and is not an empty array (query: { abacAttributes: { $exists: true, $ne: [] } }). Therefore, in components consuming this endpoint (like AdminABACRooms.tsx), room.abacAttributes is guaranteed to be defined for all returned rooms, and optional chaining before calling array methods like .join() is sufficient without additional null coalescing.

Applied to files:

• apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx

🔇 Additional comments (2)

apps/meteor/client/views/teams/contextualBar/info/TeamsInfo.tsx (2)

137-137: No action needed — component handles visibility internally.

RoomInfoABACSection implements all necessary visibility logic internally (lines 25-26 of RoomInfoABACSection.tsx): it returns null when ABAC is disabled, the display setting is off, or room.abacAttributes is empty or undefined. Unconditional rendering is the correct pattern here, consistent with how the component is used in both TeamsInfo.tsx and RoomInfo.tsx. The component's internal guards cover all scenarios.

---

28-28: Import correctly reuses ABAC section component from room info view.

The RoomInfoABACSection component is safely used unconditionally because it returns null when ABAC settings are disabled or the room lacks abacAttributes, making it appropriate for team rooms.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change	Percent
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+418B
queue-worker-service	132MiB	132MiB	-706B
ddp-streamer-service	126MiB	126MiB	-422B
account-service	113MiB	113MiB	-383B
authorization-service	111MiB	111MiB	-1.2KiB
stream-hub-service	111MiB	111MiB	-1.1KiB
presence-service	111MiB	111MiB	+259B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 00:15", "12/20 00:34 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Loading

Statistics (last 26 days):

• 📊 Average: 1.5GiB
• ⬇️ Minimum: 1.2GiB
• ⬆️ Maximum: 1.6GiB
• 🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

• Tag: pr-37869
• Baseline: develop
• Timestamp: 2025-12-20 00:34:22 UTC
• Historical data points: 26

---

Updated: Sat, 20 Dec 2025 00:34:22 GMT

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.69%. Comparing base (0b39d87) to head (22d5d8c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37869      +/-   ##
===========================================
- Coverage    67.70%   67.69%   -0.02%     
===========================================
  Files         3475     3475              
  Lines       113860   113860              
  Branches     20943    20943              
===========================================
- Hits         77093    77081      -12     
- Misses       34586    34593       +7     
- Partials      2181     2186       +5     

Flag	Coverage Δ
e2e	57.18% <ø> (-0.02%)	⬇️
e2e-api	44.01% <ø> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.