Skip to content

chore: Change call history message-block not-answered icon#37903

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
chore/updatePayloadIcon
Dec 20, 2025
Merged

chore: Change call history message-block not-answered icon#37903
kodiakhq[bot] merged 3 commits intodevelopfrom
chore/updatePayloadIcon

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 19, 2025

Proposed changes (including videos or screenshots)

Issue(s)

VGA-120

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Style
    • Updated the visual indicator for unanswered calls in call history: the icon and its color changed to more clearly represent a not-answered state.
  • Tests
    • Updated test expectations to match the revised icon and color for unanswered calls.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 1e6fc58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

Walkthrough

Updated the 'not-answered' call state mapping to use the phone-question-mark icon with variant warning instead of clock with variant danger; unit tests updated to reflect the new icon and variant.

Changes

Cohort / File(s) Change Summary
Call state icon & tests
packages/ui-voip/src/ui-kit/getHistoryMessagePayload.ts, packages/ui-voip/src/ui-kit/getHistoryMessagePayload.spec.ts
Replaced the 'not-answered' mapping: icon changed from clock (variant danger) to phone-question-mark (variant warning); updated unit tests to match new icon and variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review the updated not-answered case in callStateToIcon.
  • Confirm phone-question-mark is present in icon definitions/assets and nothing else relies on the prior icon semantics.

Possibly related PRs

Suggested reviewers

  • pierre-lehnen-rc
  • d-gubert
  • tassoevan

Poem

🐰 I swapped the clock for a curious ring,
A little question where silence did sing.
Yellow hops nudged the quiet air,
A small warm mark to show someone cared.
📞✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the icon for the 'not-answered' state in the call history message block, which matches the code changes.
Linked Issues check ✅ Passed The linked issue VGA-120 requests updating the 'not-answered' icon in the message-block, and the PR implements exactly this change with icon and variant updates.
Out of Scope Changes check ✅ Passed All changes are directly related to updating the 'not-answered' icon in call history; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/updatePayloadIcon

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 589e51c and 1e6fc58.

📒 Files selected for processing (1)
  • packages/ui-voip/src/ui-kit/getHistoryMessagePayload.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui-voip/src/ui-kit/getHistoryMessagePayload.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gabriellsh gabriellsh added this to the 7.14.0 milestone Dec 19, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +45B
queue-worker-service 132MiB 132MiB +60B
ddp-streamer-service 126MiB 126MiB +140B
account-service 113MiB 113MiB -53B
authorization-service 111MiB 111MiB -1.4KiB
stream-hub-service 111MiB 111MiB -386B
presence-service 111MiB 111MiB -387B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 07:41", "12/20 08:51 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 26 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37903
  • Baseline: develop
  • Timestamp: 2025-12-20 08:51:08 UTC
  • Historical data points: 26

Updated: Sat, 20 Dec 2025 08:51:08 GMT

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.69%. Comparing base (76d263e) to head (1e6fc58).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37903      +/-   ##
===========================================
- Coverage    67.69%   67.69%   -0.01%     
===========================================
  Files         3476     3476              
  Lines       113895   113895              
  Branches     20956    20956              
===========================================
- Hits         77098    77097       -1     
- Misses       34609    34612       +3     
+ Partials      2188     2186       -2     
Flag Coverage Δ
e2e 57.16% <ø> (+0.01%) ⬆️
e2e-api 44.01% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kodiakhq kodiakhq bot merged commit 9657d38 into develop Dec 20, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/updatePayloadIcon branch December 20, 2025 09:23
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants