Skip to content

regression(ABAC): Improve errors on attribute form #37982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 7 commits into from
Dec 31, 2025
Merged

regression(ABAC): Improve errors on attribute form #37982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b22c69
regression(ABAC): user friendly errors on attribute form
MartinSchoeler Dec 26, 2025
9074c7e
ts
MartinSchoeler Dec 26, 2025
d21970c
Merge branch 'release-8.0.0' into reg-abac-msg
MartinSchoeler Dec 29, 2025
8672974
Merge branch 'release-8.0.0' into reg-abac-msg
KevLehman Dec 29, 2025
3875f60
Merge branch 'release-8.0.0' into reg-abac-msg
MartinSchoeler Dec 29, 2025
9a9b70c
Merge branch 'release-8.0.0' into reg-abac-msg
MartinSchoeler Dec 29, 2025
181527b
Merge branch 'release-8.0.0' into reg-abac-msg
MartinSchoeler Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/meteor/client/views/admin/ABAC/ABACAttributesTab/AttributesContextualBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,12 @@ const AttributesContextualBar = ({ attributeData, onClose }: AttributesContextua
}
onClose();
},
onError: (error) => {
dispatchToastMessage({ type: 'error', message: error });
onError: (error: { errorType: string; error: string }) => {
if (error.errorType === 'invalid-params') {
dispatchToastMessage({ type: 'error', message: t('ABAC_Invalid_attribute') });
} else {
dispatchToastMessage({ type: 'error', message: error });
}
},
onSettled: () => {
queryClient.invalidateQueries({ queryKey: ABACQueryKeys.roomAttributes.list() });
Expand Down
1 change: 1 addition & 0 deletions packages/i18n/src/locales/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"ABAC_Managed_description": "Only compliant users have access to attribute-based access controlled rooms. Attributes determine room access.",
"ABAC_Room_Attributes": "Room Attributes",
"ABAC_Logs": "Logs",
"ABAC_Invalid_attribute": "Invalid characters in attribute name or values",
"AI_Actions": "AI actions",
"API": "API",
"API_Add_Personal_Access_Token": "Add new Personal Access Token",
Expand Down
Loading