-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: rename slackbridge JS files to TS #38311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Caution Review failedThe pull request is closed. WalkthroughJavaScript files in the Slack bridge module are converted to TypeScript. Header comments, lint/TS pragmas, and Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38311 +/- ##
===========================================
+ Coverage 70.73% 70.76% +0.03%
===========================================
Files 3158 3158
Lines 109359 109359
Branches 19695 19680 -15
===========================================
+ Hits 77358 77391 +33
+ Misses 29966 29943 -23
+ Partials 2035 2025 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
Proposed changes (including videos or screenshots)
The slackbridge code is being converted to typescript on #35196, along with a general refactor that was needed to write the proper type definition.
This PR is simply renaming the files to .ts in advance, so that their git history can be preserved even with heavier changes.
It'll also make potential conflicts much easier to solve.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1754
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.