-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: Upgrade fuselage packages #38418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
WalkthroughThis PR updates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38418 +/- ##
===========================================
+ Coverage 70.44% 70.47% +0.02%
===========================================
Files 3162 3162
Lines 110339 110339
Branches 19876 19855 -21
===========================================
+ Hits 77729 77761 +32
+ Misses 30576 30554 -22
+ Partials 2034 2024 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5f645d3 to
552632a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 56 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apps/meteor/ee/server/services/package.json`:
- Line 22: The dependency entry for "@rocket.chat/emitter" is pinned to a
non-existent version "^0.32.0" which will break installs; update the
package.json dependency for "@rocket.chat/emitter" to a valid published version
(for example "0.31.25") or the intended correct semver range, then run a local
install to verify resolution and update lockfile if applicable.
In `@ee/packages/ui-theming/package.json`:
- Around line 18-20: The package.json update to "@rocket.chat/fuselage":
"0.71.0" introduces ES2024 output while ui-theming's TypeScript config
(tsconfig.json extending client.json) targets ES2015, causing a
transpilation/compatibility mismatch; fix by either updating the tsconfig target
to "ES2024" (or a value that supports fuselage's emitted features) or ensure the
build chain transpiles node_modules/fuselage down to ES2015 (e.g., adjust
bundler/webpack/ts-loader rules); update package.json/peerDependencies to
reflect the correct fuselage range if you lock a transpilation strategy, and
verify no duplicate conflicting entries remain in devDependencies and
peerDependencies for "@rocket.chat/fuselage" so the published package consumers
get consistent expectations.
Proposed changes (including videos or screenshots)
Release changes:
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit