chore: allow media call clients to specify which call features they support #38574

pierre-lehnen-rc · 2026-02-09T21:04:48Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Once we integrate the media call system with Pexip and implement new features such as camera or screen sharing, we'll need to let clients specify which individual features they support. This PR is pre-creating the signal structure for that, so that the clients may already specify their supported features even before such features exist on the server.

…upport

dionisio-bot · 2026-02-09T21:04:53Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2026-02-09T21:04:57Z

⚠️ No Changeset found

Latest commit: 866fa82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-09T21:05:03Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-09T21:17:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.33%. Comparing base (9656b31) to head (866fa82).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38574      +/-   ##
===========================================
- Coverage    70.38%   70.33%   -0.05%     
===========================================
  Files         3162     3162              
  Lines       110697   110697              
  Branches     19903    19907       +4     
===========================================
- Hits         77909    77859      -50     
- Misses       30760    30803      +43     
- Partials      2028     2035       +7

Flag	Coverage Δ
e2e	`60.33% <ø> (-0.07%)`	⬇️
e2e-api	`47.73% <ø> (-1.04%)`	⬇️
unit	`71.32% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-09T21:20:58Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/10 17:04 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38574
Baseline: develop
Timestamp: 2026-02-10 17:04:50 UTC
Historical data points: 30

Updated: Tue, 10 Feb 2026 17:04:51 GMT

cubic-dev-ai

1 issue found across 21 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/media-signaling/src/definition/signals/client/request-call.ts">

<violation number="1" location="packages/media-signaling/src/definition/signals/client/request-call.ts:69">
P2: Schema allows `supportedFeatures: null`, which contradicts the TypeScript type (`CallFeature[] | undefined`). Consider making the schema non-nullable so validation matches the type.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

packages/media-signaling/src/definition/signals/client/request-call.ts

KevLehman

i'll let the nullable slide this time

tassoevan · 2026-02-10T22:14:59Z

packages/media-signaling/src/definition/call/IClientMediaCall.ts

+export type CallFeature = 'audio';
+
+export const callFeatureList: readonly CallFeature[] = ['audio'];


What about invert it?

Suggested change

export type CallFeature = 'audio';

export const callFeatureList: readonly CallFeature[] = ['audio'];

export const callFeatureList = ['audio'] as const;

export type CallFeature = (typeof callFeatureList)[keyof typeof typeof callFeatureList];

chore: allow media call clients to specify which call features they s…

62ac677

…upport

test data

9fda6dc

pierre-lehnen-rc added this to the 8.2.0 milestone Feb 10, 2026

pierre-lehnen-rc marked this pull request as ready for review February 10, 2026 13:05

pierre-lehnen-rc requested review from a team as code owners February 10, 2026 13:05

cubic-dev-ai bot reviewed Feb 10, 2026

View reviewed changes

packages/media-signaling/src/definition/signals/client/request-call.ts Show resolved Hide resolved

Merge branch 'develop' into chore/media-features

866fa82

gabriellsh approved these changes Feb 10, 2026

View reviewed changes

pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Feb 10, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2026

KevLehman approved these changes Feb 10, 2026

View reviewed changes

tassoevan reviewed Feb 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: allow media call clients to specify which call features they support #38574

chore: allow media call clients to specify which call features they support #38574

Uh oh!

pierre-lehnen-rc commented Feb 9, 2026 •

edited by atlassian bot

Loading

Uh oh!

dionisio-bot bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 9, 2026

Review skipped

Uh oh!

codecov bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

KevLehman left a comment

Uh oh!

tassoevan Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		export type CallFeature = 'audio';

		export const callFeatureList: readonly CallFeature[] = ['audio'];

chore: allow media call clients to specify which call features they support #38574

Are you sure you want to change the base?

chore: allow media call clients to specify which call features they support #38574

Uh oh!

Conversation

pierre-lehnen-rc commented Feb 9, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 9, 2026

Review skipped

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KevLehman left a comment

Choose a reason for hiding this comment

Uh oh!

tassoevan Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pierre-lehnen-rc commented Feb 9, 2026 •

edited by atlassian bot

Loading

dionisio-bot bot commented Feb 9, 2026 •

edited

Loading

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading