-
Notifications
You must be signed in to change notification settings - Fork 13.1k
fix: align managers table loading skeleton columns with header #38579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align managers table loading skeleton columns with header #38579
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f95c055 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
|
Hi team 👋 Thank you for maintaining the project and the community 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38579 +/- ##
===========================================
- Coverage 70.42% 70.36% -0.06%
===========================================
Files 3174 3174
Lines 110882 110882
Branches 19997 19940 -57
===========================================
- Hits 78088 78027 -61
- Misses 30755 30811 +56
- Partials 2039 2044 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@ScriptShah could you add a changeset for your fix? |
WalkthroughUpdates the Managers table loading skeleton to render four header cells (matching the table's four-column header) and adds a patch-level changeset entry documenting the fix for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✏️ Tip: You can disable this entire section by setting Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes (including videos or screenshots)
This pull request fixes a UI inconsistency in the Omnichannel → Managers page where the loading skeleton rendered fewer columns than the actual table header.
While data was loading, the table header displayed four columns, but the loading skeleton was configured to render only two columns. This caused a visible layout mismatch and made the loading state appear misaligned.
What was changed
Why this change is needed
Best practice for loading skeletons is to mirror the final layout as closely as possible. Aligning the number of skeleton columns with the visible header columns ensures visual consistency and avoids layout shifts during loading.
📸 Screenshot attached showing the mismatch before the fix.

📸 Screenshot attached showing the mismatch after the fix.

Issue(s)
Closes #38570
Steps to test or reproduce
Further comments
This is a small, isolated UI fix that does not affect application logic or behavior outside of the loading state. No changeset is included, as this change does not require a version bump.
COMM-129
Summary by CodeRabbit