fix: Broken user roles on Import service #38591

tassoevan · 2026-02-10T17:32:04Z

Proposed changes (including videos or screenshots)

It fix a misuse of Set in the importer service reported on PR #38528 (#38528 (comment)).

Issue(s)

ARCH-1934

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Bug Fixes
- Fixed role deduplication/merging during bulk user imports so assigned roles are consolidated correctly.
Tests
- Added a comprehensive test suite covering import operations, user handling, role assignment, status transitions, and error cases.
- Expanded server test discovery to include additional import-related spec files.

dionisio-bot · 2026-02-10T17:32:09Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-02-10T17:32:10Z

⚠️ No Changeset found

Latest commit: f7240a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-10T17:32:19Z

Walkthrough

Fixes role deduplication in ImportService.addUsers, adds a comprehensive ImportService test suite, and includes the new tests in the server Jest config.

Changes

Cohort / File(s)	Summary
Test Configuration `apps/meteor/jest.config.ts`	Added a test match to include spec files under `server/services/import/*/.spec.ts` in the server test suite.
ImportService implementation `apps/meteor/server/services/import/service.ts`	Adjusted roles deduplication: combine `data.roles` and `defaultRoles` into one array before constructing a `Set` to ensure correct role merging.
ImportService tests `apps/meteor/server/services/import/service.spec.ts`	Added a comprehensive test suite for ImportService covering: clear, newOperation (including errors), status derivation, addUsers (validation, role merging/deduplication, persistence, error cases), and run (importer retrieval and invocation).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐇 I nibbled at roles and found a stray spread,
I gathered them tidy—no duplicates ahead.
Tests now hop in, precise and spry,
Importing clean under moonlit sky. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main fix: correcting broken user roles handling in the Import service.
Linked Issues check	✅ Passed	The PR addresses the ARCH-1934 issue by fixing the Set deduplication logic in the addUsers method and includes comprehensive tests for the ImportService.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the Import service roles issue: jest configuration update, service logic fix, and comprehensive test coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41a1b72 and f7240a2.

📒 Files selected for processing (1)

apps/meteor/server/services/import/service.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

apps/meteor/server/services/import/service.spec.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-10T17:40:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.47%. Comparing base (c53312f) to head (f7240a2).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38591      +/-   ##
===========================================
+ Coverage    70.35%   70.47%   +0.11%     
===========================================
  Files         3162     3162              
  Lines       110705   110826     +121     
  Branches     19923    19975      +52     
===========================================
+ Hits         77892    78104     +212     
+ Misses       30788    30689      -99     
- Partials      2025     2033       +8

Flag	Coverage Δ
e2e	`60.43% <ø> (+0.01%)`	⬆️
e2e-api	`47.71% <0.00%> (-0.02%)`	⬇️
unit	`71.45% <100.00%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-10T17:44:58Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/10 21:40 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38591
Baseline: develop
Timestamp: 2026-02-10 21:40:15 UTC
Historical data points: 30

Updated: Tue, 10 Feb 2026 21:40:16 GMT

cubic-dev-ai

No issues found across 3 files

apps/meteor/server/services/import/service.spec.ts

tassoevan added this to the 8.2.0 milestone Feb 10, 2026

tassoevan added 2 commits February 10, 2026 16:12

fix: Broken user roles on Import service

e9acd72

test: add unit test for the Import service

41a1b72

tassoevan force-pushed the fix/import-service-roles branch from 74fb593 to 41a1b72 Compare February 10, 2026 19:12

tassoevan marked this pull request as ready for review February 10, 2026 20:37

tassoevan requested a review from a team as a code owner February 10, 2026 20:37

cubic-dev-ai bot reviewed Feb 10, 2026

View reviewed changes

ricardogarim reviewed Feb 10, 2026

View reviewed changes

apps/meteor/server/services/import/service.spec.ts Outdated Show resolved Hide resolved

ricardogarim previously approved these changes Feb 10, 2026

View reviewed changes

test: review

f7240a2

tassoevan dismissed ricardogarim’s stale review via f7240a2 February 10, 2026 21:21

KevLehman approved these changes Feb 10, 2026

View reviewed changes

ricardogarim approved these changes Feb 10, 2026

View reviewed changes

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Feb 11, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 11, 2026

tassoevan removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Feb 11, 2026

tassoevan requested a review from pierre-lehnen-rc February 11, 2026 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Broken user roles on Import service #38591

fix: Broken user roles on Import service #38591

tassoevan commented Feb 10, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Broken user roles on Import service #38591

Are you sure you want to change the base?

fix: Broken user roles on Import service #38591

Conversation

tassoevan commented Feb 10, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

codecov bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tassoevan commented Feb 10, 2026 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Feb 10, 2026 •

edited

Loading

changeset-bot bot commented Feb 10, 2026 •

edited

Loading

coderabbitai bot commented Feb 10, 2026 •

edited

Loading

codecov bot commented Feb 10, 2026 •

edited

Loading

github-actions bot commented Feb 10, 2026 •

edited

Loading