Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I encountered some errors while running the
generate_updated_hashes.pyscript on the images hosted on Synapse, in particular:TypeError: remove: path should be string, bytes or os.PathLike, not Filefor L39TypeError: Strings must be encoded before hashingfor L48UnboundLocalError: local variable 'parameters_hash_matched' referenced before assignmentfor L173There was also a few instances where the image no longer exists, so the script exits early after attempting to pull it 5 times.
Suggested in this PR are the fixes I did to get the script running, but I'm not sure if these unintentionally altered the expected output, especially since I did get some warnings about a hash mismatch for some of the images.
CC @hasan7n