Rubocop settings to minimize churn #125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesrich
reviewed
Jan 24, 2025
Contributor
wesrich
left a comment
wesrich
left a comment
There was a problem hiding this comment.
I mostly don't mind these suggestions (though some of this may fall under @mark-kraemer , and more opinions are better than fewer), just one question.
lib/generators/rolemodel/linters/rubocop/templates/.rubocop.yml
Outdated
Show resolved
Hide resolved
reedrolemodel
commented
Jan 24, 2025
lib/generators/rolemodel/linters/rubocop/templates/.rubocop.yml
Outdated
Show resolved
Hide resolved
reedrolemodel
commented
Jan 24, 2025
lib/generators/rolemodel/linters/rubocop/templates/.rubocop.yml
Outdated
Show resolved
Hide resolved
These rules reduce the number of lines highlighted by git as changed when new lines are added.
Jeremy-Walton
force-pushed
the
rubocop-minimum-churn
branch
from
1036443 to
8f570cb
Compare
Member
|
@wesrich @mark-kraemer Resurfacing this to clear it out. I haven't reviewed all these rules but I did rebase and organize the file better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
These rules reduce the number of lines highlighted by git as changed when new lines are added. See this article for a full explanation.
What Changed
What changed in this PR?